Re: feature request: add iso_week_day to querysets, analogous to iso_year

2019-09-26 Thread Anatol Ulrich
nevermind, found official dockerfiles for XE, will try those On Thu, Sep 26, 2019 at 12:58 PM Anatol Ulrich wrote: > one last thing preventing me from submitting the PR is that the > implementation is database specific and while I'm reasonably sure my oracle > implementation is correct, I don't

Re: feature request: add iso_week_day to querysets, analogous to iso_year

2019-09-26 Thread Anatol Ulrich
one last thing preventing me from submitting the PR is that the implementation is database specific and while I'm reasonably sure my oracle implementation is correct, I don't have an easy means of testing it. What's the team's go-to approach here? Cheers Anatol On Wed, Sep 25, 2019 at 2:10 PM Ana

Re: feature request: add iso_week_day to querysets, analogous to iso_year

2019-09-26 Thread Anatol Ulrich
On Thu, Sep 26, 2019 at 11:33 AM Adam Johnson wrote: > Right, my bad. > > So itt looks like we h ave week_day which has sunday = 1, while ISO week > days have monday = 1. What other "peculiar and unintuitive" behaviour is > there Anatol? > it's just that. Django's docs say it themselves (emphas

Re: feature request: add iso_week_day to querysets, analogous to iso_year

2019-09-26 Thread Adam Johnson
Right, my bad. So itt looks like we h ave week_day which has sunday = 1, while ISO week days have monday = 1. What other "peculiar and unintuitive" behaviour is there Anatol? On Wed, 25 Sep 2019 at 15:39, Mariusz Felisiak wrote: > In this ticket we mentioned *iso_week* not *iso_week_day*. *wee

Re: feature request: add iso_week_day to querysets, analogous to iso_year

2019-09-25 Thread Mariusz Felisiak
In this ticket we mentioned *iso_week* not *iso_week_day*. *week *lookup returns the week number (1-52 or 53) according to ISO-8601 (https://en.wikipedia.org/wiki/ISO-8601), that's why *iso_week *is not necessary. -- You received this message because you are subscribed to the Google Groups "D

Re: feature request: add iso_week_day to querysets, analogous to iso_year

2019-09-25 Thread Adam Johnson
I found the ticket for iso_year, it also mentioned weeks but didn't end up implementing it: https://code.djangoproject.com/ticket/28649 I'm not quite sure why. You probably know more than me. Please open a nwe ticket and create a PR ("patch") for it with your code - instructions for all those on h

feature request: add iso_week_day to querysets, analogous to iso_year

2019-09-25 Thread Anatol Ulrich
Hello! As the subject states I'd like to see iso_week_day in the queryset API (in fact, I have already implemented it in my local django fork...), for consistency reasons (iso_year already exists), and because the way week_day works is quite peculiar and unintuitive. Cheers Anatol -- You rece