Re: django.utils.simplejson + stdlib json

2013-04-13 Thread Alex Ogier
This problem was gonna have to be eventually sorted through no matter what: the endgame was decided to be "json from the standard library everywhere" which means any projects doing simplejson.dumps([django internals]) would inevitably be affected sooner or later. In theory it's just as distasteful

Re: django.utils.simplejson + stdlib json

2013-04-13 Thread Aymeric Augustin
On 13 avr. 2013, at 22:13, Jeremy Dunck wrote: > After reading that ticket, I'm not sure what Alex and I are > disagreeing on. I was suggesting using django.utils.simplejson > internally until it's removed, so that at least people could be > consistent with django itself. That way, DjangoJSONEn

Re: django.utils.simplejson + stdlib json

2013-04-13 Thread Jeremy Dunck
After reading that ticket, I'm not sure what Alex and I are disagreeing on. I was suggesting using django.utils.simplejson internally until it's removed, so that at least people could be consistent with django itself. That way, DjangoJSONEncoder would be a simplejson.JSONEncoder (if simplejson is

Re: django.utils.simplejson + stdlib json

2013-04-12 Thread Aymeric Augustin
2013/4/12 Jeremy Dunck > I think we broke backwards-compat here - django 1.5.1. plus sentry > 5.4.5 dies because django's own DjangoJSONEncoder depends on stdlib > json, but sentry (and lots of things) use django.utils.simplejson, > which uses simplejson if available. We did break backwards com

Re: django.utils.simplejson + stdlib json

2013-04-11 Thread Jeremy Dunck
Yes, sorry, am mobile right now. Thanks Mr Ogier. :) On Apr 11, 2013, at 6:44 PM, Alex Ogier wrote: > I think what he is saying is that many third-party libraries call the > equivalent of django.utils.simplejson.dumps("...", > cls=DjangoJSONEncoder) which, despite django.utils.simplejson only >

Re: django.utils.simplejson + stdlib json

2013-04-11 Thread Alex Ogier
I think what he is saying is that many third-party libraries call the equivalent of django.utils.simplejson.dumps("...", cls=DjangoJSONEncoder) which, despite django.utils.simplejson only being in a pending deprecation state, is broken. On Thu, Apr 11, 2013 at 9:22 PM, Alex Gaynor wrote: > When d

Re: django.utils.simplejson + stdlib json

2013-04-11 Thread Alex Gaynor
When doing what? What do I need to do to trigger this? Alex On Apr 11, 2013 6:16 PM, "Jeremy Dunck" wrote: > If a user of django has simplejson installed, django itself will use both > the stdlib and simplejson. > > On Apr 11, 2013, at 5:54 PM, Alex Gaynor wrote: > > I basically agree with what

Re: django.utils.simplejson + stdlib json

2013-04-11 Thread Jeremy Dunck
If a user of django has simplejson installed, django itself will use both the stdlib and simplejson. On Apr 11, 2013, at 5:54 PM, Alex Gaynor wrote: > I basically agree with what Bob said on the ticket, it's unclear to me from > your email how this manifests, other than trying to use somethin

Re: django.utils.simplejson + stdlib json

2013-04-11 Thread Alex Gaynor
I basically agree with what Bob said on the ticket, it's unclear to me from your email how this manifests, other than trying to use something from the standard library with simplejson, which is obviously wrong. Alex On Thu, Apr 11, 2013 at 5:51 PM, Jeremy Dunck wrote: > I've just seen a docume

django.utils.simplejson + stdlib json

2013-04-11 Thread Jeremy Dunck
I've just seen a documented example of this breaking things in the wild. https://github.com/simplejson/simplejson/issues/37 I think we broke backwards-compat here - django 1.5.1. plus sentry 5.4.5 dies because django's own DjangoJSONEncoder depends on stdlib json, but sentry (and lots of things)