Re: django.core.signing and safe characters

2017-06-21 Thread Ole Laursen
2017-06-21 15:26 GMT+02:00 Florian Apolloner : > Sorry I've mixed it up with with encodeURI. encodeURIComponent takes the > "safe" route and escapes everything (at least as far as I understand it) > because it does not know where the component (unless "component" itself has > a sepcific meaning tha

Re: django.core.signing and safe characters

2017-06-21 Thread Florian Apolloner
Hi Ole, On Wednesday, June 21, 2017 at 12:42:39 PM UTC+2, Ole Laursen wrote: > > I'm sorry if I gave the impression that I'm trying to nitpick > adherence to a standard. > You absolutely did not, I guess my mail was tenser than it was intended to be. > What I'm addressing here is specificall

Re: django.core.signing and safe characters

2017-06-21 Thread Ole Laursen
Hi again! I'm sorry if I gave the impression that I'm trying to nitpick adherence to a standard. There was some discussion about it in the comments in the link I provided, and it looks like there are different interpretations, but that's not what I'm interested in. What I'm addressing here is spe

Re: django.core.signing and safe characters

2017-06-20 Thread Florian Apolloner
Hi, On Tuesday, June 20, 2017 at 12:18:21 PM UTC+2, Ole Laursen wrote: > > Yet, : is specifically mentioned as a reserved character: > It depends on the context. The assumption here is that the encoded data is always used as part of the path/querystring, for which rfc1738 says: Within the and

django.core.signing and safe characters

2017-06-20 Thread Ole Laursen
Hi! Maybe this has no practical implications, but this has been bugging me for a couple of years now, ever since I started using django.core.signing to generate tokens: if you take a look at https://github.com/django/django/blob/master/django/core/signing.py the comment at the top says T