Re: django 1.5 incompatibility at TemplateView

2012-08-19 Thread Marc Tamlyn
Correct :) On Sunday, 19 August 2012 20:44:11 UTC+1, Bernardo wrote: > > So as long as I don't use the `params` thing (which I don't) there will be > no problem with my views? > Reading this and the other commit done at the same time, looks like the > function calls behave the way I expect :) >

Re: django 1.5 incompatibility at TemplateView

2012-08-19 Thread Bernardo
So as long as I don't use the `params` thing (which I don't) there will be no problem with my views? Reading this and the other commit done at the same time, looks like the function calls behave the way I expect :) Bernardo Em domingo, 19 de agosto de 2012 06h44min03s UTC-3, Marc Tamlyn escrev

Re: django 1.5 incompatibility at TemplateView

2012-08-19 Thread Marc Tamlyn
Hi Bernado, Template view passing params into the context rather than just passing the kwargs from the urlconf directly is actally somewhat older, and is kept as legacy from django.views.generic.simple.direct_to_template. The changes you refer to do actually introduce a subtle backwards incompa

django 1.5 incompatibility at TemplateView

2012-08-18 Thread Bernardo
Hi, I was trying my project on django 1.5 alpha and a change on TemplateViews made some code break. The `get` method changed how `get_context_data` is called from (**kwargs)to (params=kwargs). Link: https://github.com/django/django/blob/master/django/views/generic/base.py I traced the change a