Re: db backend refactoring

2007-08-22 Thread Brian Harring
On Mon, Aug 20, 2007 at 03:13:52PM +1000, Malcolm Tredinnick wrote: > > On Sun, 2007-08-19 at 23:01 -0500, Adrian Holovaty wrote: > [...] > > I haven't yet made DatabaseError, IntegrityError and the introspection > > and creation functionality accessible via the django.db.connection > > object. Th

Re: db backend refactoring

2007-08-19 Thread Malcolm Tredinnick
On Sun, 2007-08-19 at 23:01 -0500, Adrian Holovaty wrote: [...] > I haven't yet made DatabaseError, IntegrityError and the introspection > and creation functionality accessible via the django.db.connection > object. Those changes can happen in the near future, if they need to > be made. If we do

Re: db backend refactoring

2007-08-19 Thread Adrian Holovaty
On 8/13/07, Brian Harring <[EMAIL PROTECTED]> wrote: > As hinted at earlier on the ml, have started doing some work on > refactoring the actual db backend; ticket 5106 holds the current > version (http://code.djangoproject.com/ticket/5106). I've implemented pretty much all of this in a flurry of

Re: db backend refactoring

2007-08-14 Thread Brian Harring
On Wed, Aug 15, 2007 at 09:46:43AM +0700, Ben Ford wrote: >Hi Brian, >Just a quick question from me regarding your comment about supporting >multiple databases... I've had a quick look through your patch and it >seems to cover a lot of the ground that the multi-db has already >c

Re: db backend refactoring

2007-08-14 Thread Ben Ford
Hi Brian, Just a quick question from me regarding your comment about supporting multiple databases... I've had a quick look through your patch and it seems to cover a lot of the ground that the multi-db has already changed. - I was wondering if you're familiar at all with mulitple-db branch

Re: db backend refactoring

2007-08-14 Thread Brian Harring
On Tue, Aug 14, 2007 at 04:36:22PM -0500, Adrian Holovaty wrote: > After a cursory read-through the patch, my only major complaint is the > unnecessary cleverness of some of the code. Alt example besides BackendOps/BackendCapabilities would be appreciated (your phrasing implies there is more); t

Re: db backend refactoring

2007-08-14 Thread Adrian Holovaty
On 8/13/07, Brian Harring <[EMAIL PROTECTED]> wrote: > As hinted at earlier on the ml, have started doing some work on > refactoring the actual db backend; ticket 5106 holds the current > version (http://code.djangoproject.com/ticket/5106). Hey Brian, These look like solid improvements to me. A

Re: db backend refactoring

2007-08-13 Thread Gary Wilson
Brian Harring wrote: > So... thoughts? The second round of refactoring posted on 5106 > currently lacks some of the new features mentioned above (need to port > them over mainly), but v3l address that, and add in at least a > SteadyDB persistant connection (pooling would be based off that). T

db backend refactoring

2007-08-13 Thread Brian Harring
As hinted at earlier on the ml, have started doing some work on refactoring the actual db backend; ticket 5106 holds the current version (http://code.djangoproject.com/ticket/5106). Best to start with perceived cons of current design of the backends- 1) redundancy of code; each backend implemen