Re: backend-specific escaping

2005-11-29 Thread Adrian Holovaty
On 11/29/05, jws <[EMAIL PROTECTED]> wrote: > If this sounds reasonable, I'll attach my diff to the original ticket, > re-open it and continue the discussion there. Sounds good! Adrian -- Adrian Holovaty holovaty.com | djangoproject.com | chicagocrime.org

Re: backend-specific escaping

2005-11-29 Thread jws
If this sounds reasonable, I'll attach my diff to the original ticket, re-open it and continue the discussion there.

Re: backend-specific escaping

2005-11-29 Thread Adrian Holovaty
On 11/29/05, Amit Upadhyay <[EMAIL PROTECTED]> wrote: > Each backend class grew escapeChars() method. > It raises NotImplemented if its not implemented/NotPossible if escaping can > not be done without an open connection. > Your original change tries to use escapeChars and if no exception is throw

Re: backend-specific escaping

2005-11-29 Thread Amit Upadhyay
On 11/29/05, jws <[EMAIL PROTECTED]> wrote: OK, so this is not a problem when we are working with the databases'live', since they are using parameterized queries. It IS a problemwhen using the 'install' and 'sql' sub-commands, since those are builtup using simple string concatenation. So if all the

Re: backend-specific escaping

2005-11-29 Thread jws
OK, so this is not a problem when we are working with the databases 'live', since they are using parameterized queries. It IS a problem when using the 'install' and 'sql' sub-commands, since those are built up using simple string concatenation. So if all the following were true, would this be acc

Re: backend-specific escaping

2005-11-29 Thread Adrian Holovaty
On 11/29/05, jws <[EMAIL PROTECTED]> wrote: > I'd like to clarify the reasoning, since I think it pertains to a > larger issue. My understanding of Adrian's comment is that there > currently is no infrastructure in Django to escape special characters > in strings in a way that is specific to each

Re: backend-specific escaping

2005-11-29 Thread Maniac
jws wrote: My ticket was closed - http://code.djangoproject.com/ticket/470 I'd like to clarify the reasoning, since I think it pertains to a larger issue. My understanding of Adrian's comment is that there currently is no infrastructure in Django to escape special characters in strings in a wa

backend-specific escaping

2005-11-28 Thread jws
My ticket was closed - http://code.djangoproject.com/ticket/470 I'd like to clarify the reasoning, since I think it pertains to a larger issue. My understanding of Adrian's comment is that there currently is no infrastructure in Django to escape special characters in strings in a way that is spec