Re: User.username max_length 254

2015-10-29 Thread Dheerendra Rathor
Hello All, Since username length is going to increased from 30 to 254 (PR #5497 ), I personally think first_name and last_name field length should be increased as well. Practically many first names are of length > 30, this is quite common in southern

Re: User.username max_length 254

2015-07-09 Thread Collin Anderson
Hi Anders, I think we need to make it as easy as possible for people to add back the 30-character restriction if they want, especially in the admin. Really good documentation of what to do should be good enough I hope, but we need to make sure it's easy and there aren't too many side-effects.

Re: User.username max_length 254

2015-07-09 Thread Anders Petersson
Hey, I would like to see this get into 1.9, Can anyone suggest whats needed to merge https://github.com/django/django/pull/4250 ? On Tuesday, June 2, 2015 at 3:18:35 AM UTC+2, Ryan Floyd wrote: > > I solved this in a very hacky way, without touching any django code. I'll > probably break the fo

Re: User.username max_length 254

2015-06-01 Thread Ryan Floyd
I solved this in a very hacky way, without touching any django code. I'll probably break the forms 1. Create an empty migration (python manage.py makemigrations --name extend_username_field --empty [app_name]) 2. Inside the migration, add: ``` operations = [ migrations.RunSQL('ALTER TABLE au

Re: User.username max_length 254

2015-04-22 Thread Micah Hausler
I actually migrated my site to 1.7 and added a custom user model very easily. Here's a gist with the code, https://gist.github.com/micahhausler/63636f26cc87bb966218, but essentially all I had to do was add a new user app, copy the Django AbstractUser code, and set the db_table to 'auth_user'.

Re: User.username max_length 254

2015-04-19 Thread Collin Anderson
Hi All, I'm pretty busy right now and don't currently have the time and motivation to finish this username max_length 254 change. If anyone wants to finish it up, the PR is nearly complete; it just needs better instructions on how to keep the limit at 30 characters for anyone who doesn't want t

Re: User.username max_length 254

2015-03-06 Thread Collin Anderson
Hi All, I made a pull request. https://github.com/django/django/pull/4250/files I wish I would have thought of this two months ago, but I think it's too big of a change to get into 1.8 this late. I personally don't want to potentially have the release delayed because of possible issues with thi

Re: User.username max_length 254

2015-03-06 Thread Chris Foresman
Yeah, this is the point I was trying to make. I absolutely get your point about the impact to user, though, Josh. It just seems worth doing since this is an LTS release. On Friday, February 27, 2015 at 5:41:12 PM UTC-6, Daniel Hawkins wrote: > > I'd bet an extremely large portion of those users

Re: User.username max_length 254

2015-02-27 Thread Daniel Hawkins
> > I'd bet an extremely large portion of those users don't absolutely have to > have an increased username field. They've gone this long without it. > They (we) have gone this long, not because we didn't need it, but because we didn't think of it in the very beginning, and after that it was too

Re: User.username max_length 254

2015-02-25 Thread Josh Smeaton
As Tim pointed out, it's unlikely that the change would have made Alpha, let alone Beta. Adding a new feature now breaks the 'philosophical' release rules but it also allows a feature through without the wider community testing in alpha and beta (now that it's cut). As far as I can tell, increa

Re: User.username max_length 254

2015-02-25 Thread Chris Foresman
Given that 1.8 is an LTS, and increasing the default username length addresses the 80% use-case for custom user models, isn't it worth adding this change now (even if it philosophically violates the alpha/beta split)? On Wednesday, February 25, 2015 at 12:24:20 PM UTC-6, Tim Graham wrote: > >

Re: User.username max_length 254

2015-02-25 Thread Tim Graham
Well, this change wouldn't have been made after alpha (feature-freeze) either. As there haven't been any outright rejections of the idea, I think the next step is for someone to write a patch and carefully consider and document and backwards compatibility concerns. On Wednesday, February 25, 20

Re: User.username max_length 254

2015-02-25 Thread Collin Anderson
Hi, I'm actually about to run into a similar situation myself where I already have migrations for my project but need to start using a custom user model (because I need a longer username :). There's talk of possibly including a custom user in the project template https://code.djangoproject.com

Re: User.username max_length 254

2015-02-25 Thread Daniel Hawkins
> > Beta 1 marks the end of any changes that aren't considered release > blocking bugs. A bug is a "Release blocker" if it's a regression from a > previous version of Django or if it's an important bug in a new feature. ... so I guess the ship has sailed on this idea? :( On Wednesday, Februa

Re: User.username max_length 254

2015-02-11 Thread Daniel Hawkins
Yes please! Since contrib.auth.models.User.email is an EmailField, that change will require everyone to run a migration, right? Then we might as well change the character limit on the username field at the same time, no? And any other defaults that might be less-than-reasonable? I was going

Re: User.username max_length 254

2015-02-09 Thread Wim Feijen
Hi Collin, I would like that, good idea! Wim On Saturday, 7 February 2015 02:10:02 UTC+1, Collin Anderson wrote: > > Hi All, > > I was reminded by: > Allow shadowing of abstract fields > https://groups.google.com/d/msg/django-developers/6zUfnElOIks/8uwXji559EsJ > and https://code.djangoproject

User.username max_length 254

2015-02-06 Thread Collin Anderson
Hi All, I was reminded by: Allow shadowing of abstract fields https://groups.google.com/d/msg/django-developers/6zUfnElOIks/8uwXji559EsJ and https://code.djangoproject.com/ticket/24288 (Custom User Models for small tweaks). Could we reopen https://code.djangoproject.com/ticket/20846 and increas