Re: Use RequestContext if possible in default 500 error view

2009-04-30 Thread Alex Gaynor
On Thu, Apr 30, 2009 at 9:57 PM, Collin Grady wrote: > > Perhaps the default 500 view could just include a few simple things > like MEDIA_URL on its own? > > Alternatively, one can make a custom 500 handler with whatever info > they want, instead of using django's default :) > > -- > Collin Grady

Re: Use RequestContext if possible in default 500 error view

2009-04-30 Thread Collin Grady
Perhaps the default 500 view could just include a few simple things like MEDIA_URL on its own? Alternatively, one can make a custom 500 handler with whatever info they want, instead of using django's default :) -- Collin Grady --~--~-~--~~~---~--~~ You received

Re: Use RequestContext if possible in default 500 error view

2009-04-30 Thread James Bennett
On Thu, Apr 30, 2009 at 6:31 PM, Igor Sobreira wrote: > Because it violates DRY, and will mess the template inheritante. The problem is that this isn't actually an argument. It's just a statement. The real thing to consider here is what trade-off is being made: in return for having to do a bit

Re: Use RequestContext if possible in default 500 error view

2009-04-30 Thread Mike Panchenko
I don't think errors in error templates is a problem specific to Django. I've run into this problem in other frameworks, including when I was messing around with my own in PHP. If you have an exception handler that is itself a candidate for exceptions, you end up with trouble. -1 for showing the u

Re: Use RequestContext if possible in default 500 error view

2009-04-30 Thread Igor Sobreira
On Thu, Apr 30, 2009 at 10:43 AM, Karen Tracey wrote: > > With the try/except, if in fact there's trouble creating RequestContext or > rendering with it, the code will fall back to rendering with just an empty > Context. So the template still has to handle displaying properly in the > absence of

Re: Use RequestContext if possible in default 500 error view

2009-04-30 Thread Karen Tracey
On Thu, Apr 30, 2009 at 1:59 AM, Igor Sobreira wrote: > Hello devs, > As you know, the view django.views.defaults.server_error() uses Context > instead of RequestContext. > There are 2 tickets about it: > http://code.djangoproject.com/ticket/5617 > http://code.djangoproject.com/ticket/6377 (duplic

Use RequestContext if possible in default 500 error view

2009-04-29 Thread Igor Sobreira
Hello devs, As you know, the view django.views.defaults.server_error() uses Context instead of RequestContext. There are 2 tickets about it: http://code.djangoproject.com/ticket/5617 http://code.djangoproject.com/ticket/6377 (duplicated) ubernostrum explaied why it works that way: "The default serv