Re: URLValidator on urls without protocol

2012-11-17 Thread Jared Martin
Yes it indeed was. That was a mistake on my part. I saw it as soon as I submitted. Sorry. On Nov 17, 2012, at 11:32 PM, Karen Tracey wrote: > On Sun, Nov 18, 2012 at 12:21 AM, Jared Martin wrote: > I don't mean to wake a dead dog, but what has become of this? I came across > this problem tod

Re: URLValidator on urls without protocol

2012-11-17 Thread Karen Tracey
On Sun, Nov 18, 2012 at 12:21 AM, Jared Martin wrote: > I don't mean to wake a dead dog, but what has become of this? I came > across this problem today. For now, I've subclassed. But it should be > fixed, right? > > Yes, it should be fixed. Per the ticket referenced it was fixed two years ago. Th

Re: URLValidator on urls without protocol

2012-11-17 Thread Jared Martin
I don't mean to wake a dead dog, but what has become of this? I came across this problem today. For now, I've subclassed. But it should be fixed, right? On Sunday, June 20, 2010 7:35:23 PM UTC-6, Samus_ wrote: > > ticket: http://code.djangoproject.com/ticket/13804 > > also found a real-life scena

Re: URLValidator on urls without protocol

2010-06-20 Thread Michael Cetrulo
ticket: http://code.djangoproject.com/ticket/13804 also found a real-life scenario when this feature of the RFC is implemented, the site reddit.com uses it for a shortcut that searchs/submits links to their website, example: http://www.reddit.com/s/http://code.djangoproject.com/ticket/13804 On Sa

Re: URLValidator on urls without protocol

2010-06-12 Thread MIL
I was the guy that brought it up on #django And I would like to follow this thread. Thanks :o) Michael Hjulskov -- You received this message because you are subscribed to the Google Groups "Django developers" group. To post to this group, send email to django-develop...@googlegroups.com. To un

Re: URLValidator on urls without protocol

2010-06-11 Thread Michael Cetrulo
turns out there is a problem, the field looks for "://" anywhere on the value but according to the RFC the colon is allowed on paths, so an url like 'www.example.com/://' should validate and it fails: Python 2.6.4 (r264:75706, Jan 25 2010, 08:55:26) [GCC 4.4.2 20091208 (prerelease)] on linux2 Type

Re: URLValidator on urls without protocol

2010-06-11 Thread Michael Cetrulo
looking at the order in which the methods are called on the Field class it seems the default "http://"; is added before the validator gets called so it should work as expected, don't know where the error in validation was coming from. On Fri, Jun 11, 2010 at 2:28 PM, Michael Cetrulo wrote: > hell

URLValidator on urls without protocol

2010-06-11 Thread Michael Cetrulo
hello, something just came up on #django and I think it's worth asking here; turns out current URLValidator http://code.djangoproject.com/browser/django/tags/releases/1.2.1/django/core/validators.py#L41forbids urls without protocol however the URLField that uses it tries to add a default "http://";