Re: Try out new inline features [GSoC admin-ui]

2009-07-09 Thread patrickk
more notes: currently, the comments with selector-inlines are quite simple (basically, just textfields). does it also work with m2m-fields, rich-text-editors, foreignkeys and so on? I´m especially interested if the re-setting of each field works if you add a comment. regards, patrick On 9 Jul.,

Re: Try out new inline features [GSoC admin-ui]

2009-07-08 Thread Margie
Hey Zain, Just tried out your new stuff. Very cool! A couple comments: ## I agree that a checkbox as a drag handle is confusing - I kept trying to "check" it and didn't even realize it was a drag handle till later ## I find the numbering that shows up on the comments in your sandbox site to b

Re: Try out new inline features [GSoC admin-ui]

2009-07-07 Thread Ulrich Petri
Am 06.07.2009 um 11:20 schrieb Zain Memon: > Play around and let me know what you think -- especially if you run > into any bugs :) Hi, looks nice. But there are a few things that don't quite "feel right" yet: - The Drag handle looks like a checkbox as Adys already said - The calculation o

Re: Try out new inline features [GSoC admin-ui]

2009-07-07 Thread Dougal Matthews
I was just messing around with it and got this error; http://dpaste.com/64095/ Not exactly sure what I did to cause it though. Cheers, Dougal --- Dougal Matthews - @d0ugal http://www.dougalmatthews.com/ 2009/7/7 patrickk > > another more severe problem ... I´m going to stop writing after

Re: Try out new inline features [GSoC admin-ui]

2009-07-07 Thread patrickk
another more severe problem ... I´m going to stop writing after this one ;-) when adding items with stacked-inlines, every comment automatically gets a value for the order-field. this means, when I´m adding a comment (without entering anything) and click on "save" I´m getting an error. this obvio

Re: Try out new inline features [GSoC admin-ui]

2009-07-07 Thread patrickk
more feedback to your inline-solution: ### if you use a draghandler for stacked-inlines, there should be a draghandler for tabular-inlines as well (instead of dragging the whole row). ### deleting stacked-inlines: not sure if the delete-button should be displayed with the selectors (near the dragh

Re: Try out new inline features [GSoC admin-ui]

2009-07-07 Thread Zain Memon
Hey Patrick -- On Tue, Jul 7, 2009 at 1:04 AM, patrickk wrote: > > [snip] > > there´s a lot more to say here, but I´m not sure if this is somehow > related to your work - not sure if you only work on the inline-stuff > or the admin-interface overall. Both my GSoC project and future interests l

Re: Try out new inline features [GSoC admin-ui]

2009-07-07 Thread Tom Evans
On Tue, 2009-07-07 at 09:45 +0100, Andy Baker wrote: > Mmmm. That's a fair point but that article was written before web > applications were so application-ey and expectations may well have > changed. (I've noticed a lot of semi-modal dialogs in web apps > complete with 'cancel' buttons and with j

Re: Try out new inline features [GSoC admin-ui]

2009-07-07 Thread Andy Baker
Mmmm. That's a fair point but that article was written before web applications were so application-ey and expectations may well have changed. (I've noticed a lot of semi-modal dialogs in web apps complete with 'cancel' buttons and with javascript dialogs the back button doesn't do what Jakob impli

Re: Try out new inline features [GSoC admin-ui]

2009-07-07 Thread Tom Evans
On Mon, 2009-07-06 at 07:26 -0700, andybak wrote: > Nice! > > Are you planning to do anything to finesse the behaviour of the > 'delete' button? It would be nice (especially on selector inlines) if > it looked like items disappeared immediately. > > I also feel the admin change pages needs a 'ca

Re: Try out new inline features [GSoC admin-ui]

2009-07-07 Thread patrickk
hi zain, I´m not sure if this is the right place to start a discussion about usability testing, but I still post the main issues here ... see http://code.google.com/p/django-grappelli/wiki/djangoissues for further details. the main problem for our clients is the admin index page and how "install

Re: Try out new inline features [GSoC admin-ui]

2009-07-06 Thread Zain Memon
Thanks for the feedback, everyone. I'll focus on improving error handling and styles to make reordering more intuitive. patrickk and andybak: I'd love to hear your findings from usability tests. I will be in a pretty good position to implement fixes you suggest (barring community approval) once GSo

Re: Try out new inline features [GSoC admin-ui]

2009-07-06 Thread patrickk
@aniybak: yes, we´re doing usability-tests very frequently. that´s one reason why we came up with django-grappelli ... btw, I absolutely agree with the "cancel-button". about the delete-button: IMHO, one needs the possibility to undo the deletion - that´s why it´s almost impossible to let items

Re: Try out new inline features [GSoC admin-ui]

2009-07-06 Thread andybak
Nice! Are you planning to do anything to finesse the behaviour of the 'delete' button? It would be nice (especially on selector inlines) if it looked like items disappeared immediately. I also feel the admin change pages needs a 'cancel' button. It's quite counter-intuitive that the way to leave

Re: Try out new inline features [GSoC admin-ui]

2009-07-06 Thread Adys
Hi Zain This looks very good. One minor complaint; the checkbox-ish design of the handle is a bit counter-intuitive. Is it possible to have it on the right like the other handle, and only be able to grab it from the left side (gmail-ish interface)? Hoping this makes into trunk soon! J On Jul 6

Re: Try out new inline features [GSoC admin-ui]

2009-07-06 Thread patrickk
very nice ... some things I´ve came across: - the ordering is not preserved in case of errors. - with stacked inlines, an error should be indicated on the left-hand side (with comment-selectors). otherwise one has to click through all selectors. - with stacked inlines, there´s something wrong wit

Try out new inline features [GSoC admin-ui]

2009-07-06 Thread Zain Memon
Hi everyone, In the last couple of weeks, I've implemented a bunch of inline features. Pictures speak louder than words, so I wrote up a quick blog post describing what's done: http://inzain.net/blog/2009/07/new-features-for-inlines/ Also, I set up a server running my Django branch if you want to