Re: Trac #22343 -- select-for-update in autocommit mode

2014-04-24 Thread Marti Raudsepp
On Wed, Apr 23, 2014 at 5:43 PM, Shai Berger wrote: > We are limiting the breaking of backwards compatibility as much as we can. Fair enough. > On the contrary, my > intuition is that people using select_related are generally aware of the form > of generated SQL, and should expect locking as the

Re: Trac #22343 -- select-for-update in autocommit mode

2014-04-23 Thread Shai Berger
Hi Marti, On Tuesday 22 April 2014 18:37:37 Marti Raudsepp wrote: > On Thu, Mar 27, 2014 at 4:20 PM, Shai Berger wrote: > > The relevant tests do a select-for-update to verify that the "for update" > > clause is, indeed, added; and they happen to run in autocommit mode. They > > fail because, und

Re: Trac #22343 -- select-for-update in autocommit mode

2014-04-22 Thread Marti Raudsepp
On Thu, Mar 27, 2014 at 4:20 PM, Shai Berger wrote: > The relevant tests do a select-for-update to verify that the "for update" > clause is, indeed, added; and they happen to run in autocommit mode. They fail > because, under Oracle, in autocommit mode, the automatic commit happens > immediately a

Re: Trac #22343 -- select-for-update in autocommit mode

2014-04-02 Thread Shai Berger
On Monday 31 March 2014 09:18:57 Anssi Kääriäinen wrote: > On 03/30/2014 07:48 PM, Shai Berger wrote: > > While fixing this, I ran into this line in the current docs: > > """ > > Using select_for_update on backends which do not support SELECT ... FOR > > UPDATE (such as SQLite) will have no effect.

Re: Trac #22343 -- select-for-update in autocommit mode

2014-03-30 Thread Anssi Kääriäinen
On 03/30/2014 07:48 PM, Shai Berger wrote: On Thursday 27 March 2014 19:59:52 Aymeric Augustin wrote: On 27 mars 2014, at 15:20, Shai Berger wrote: So I'm suggesting we change the behavior of select-for-update queries, to error out when executed with no transaction. This is a backwards-incompa

Re: Trac #22343 -- select-for-update in autocommit mode

2014-03-30 Thread Shai Berger
On Thursday 27 March 2014 19:59:52 Aymeric Augustin wrote: > On 27 mars 2014, at 15:20, Shai Berger wrote: > > So I'm suggesting we change the behavior of select-for-update queries, to > > error out when executed with no transaction. This is a > > backwards-incompatible change -- for some projects

Re: Trac #22343 -- select-for-update in autocommit mode

2014-03-27 Thread Aymeric Augustin
On 27 mars 2014, at 15:20, Shai Berger wrote: > However, with any backend, select-for-update in autocommit mode makes very > little sense. Even if it doesn't break (as it does on Oracle), it doesn't > really lock anything. So, IMO, executing a query that is a select-for-update > in autocommit

Trac #22343 -- select-for-update in autocommit mode

2014-03-27 Thread Shai Berger
Hi, Ticket #22343[1] is about a couple of tests failing under Oracle. But it raises a question that's a little deeper. The relevant tests do a select-for-update to verify that the "for update" clause is, indeed, added; and they happen to run in autocommit mode. They fail because, under Oracle,