Hello !
Sorry for the trouble. I'll keep this in mind.
Thanks
Priyansh
--
You received this message because you are subscribed to the Google Groups
"Django developers (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to d
Please keep the conversation just on the pull request, and don't bug for
review after a day. There are many patches to review, and half the work is
done by volunteers in their spare time (I am one). Beware that there are 11,195
people subscribed to this mailing list.
On 21 January 2018 at 07:56,
You could use
```
if settings_dict.get('NAME') and len(settings_dict['NAME'])
```
if you wanted to prevent a KeyError too.
On Sunday, January 21, 2018 at 8:56:40 AM UTC+1, askpr...@gmail.com wrote:
>
> Hello !
>
> I have updated the PR as per Adam's review. However, I have not changed
> L155 in b
Hello !
I have updated the PR as per Adam's review. However, I have not changed
L155 in backends/postgresql/base.py from
if settings_dict['NAME'] is not None
to
if 'NAME' in settings_dict
*None may be used to connect to the default 'postgres' db. *
*However, "if 'NAME' in settings_dict" pr
Hello !
I updated the PR as per your comments, and I have run into the problem of
failing checks, while they run fine on my system. I have fixed the problem of
flake8 build-failure. However, I am unable to resolve the issue of
ImportFailure of psycopg2.
Is it because of some environment change
Hello Adam !
I created a PR as per your suggestion, and updated the ticket with the 'has
patch' flag. Please review the patch, and do give your suggestions.
Thanks !
Priyansh
--
You received this message because you are subscribed to the Google Groups
"Django developers (Contributions to Dja
It's a lot easier to review code changes if you submit a pull request, and
you'll get much more attention for a pull request with passing tests than
pasting a stack trace to the mailing list. Here's the how-to:
https://docs.djangoproject.com/en/dev/internals/contributing/writing-code/submitting-pat
Hello !
I have made a simple change to the django/db/backends/postgresql/base.py and
added a NotSupportedError for the database-name. The result of the
makemigrations command currently looks like this:
Traceback (most recent call last):
File "manage.py", line 15, in
execute_from_command_
reetings !
>
> I am looking to start contributing to the project, through ticket #29015 (
> https://code.djangoproject.com/ticket/29015).
>
> How should the erroneous database-name be handled ? I am planning to abort
> database-creation, with an appropriate error-message on the console.
Greetings !
I am looking to start contributing to the project, through ticket #29015
(https://code.djangoproject.com/ticket/29015).
How should the erroneous database-name be handled ? I am planning to abort
database-creation, with an appropriate error-message on the console. Is that
the
10 matches
Mail list logo
