Re: Re: Ticket #2773: django.views.defaults.server_error should use RequestContext

2006-09-22 Thread James Bennett
On 9/22/06, Afternoon <[EMAIL PROTECTED]> wrote: > James, why are context processors not able to handle exceptions and > fall back to basic output, i.e. return an empty dictionary? Your context processor function could, if it wanted, wrap some of its own possibly problematic code in a try/except

Re: Ticket #2773: django.views.defaults.server_error should use RequestContext

2006-09-22 Thread Michael Radziej
Afternoon schrieb: > Ivan, you're right to note that I can supply my own view. I will do > that. > > James, why are context processors not able to handle exceptions and > fall back to basic output, i.e. return an empty dictionary? Hmm, I generally prefer a good traceback instead of getting miss

Re: Ticket #2773: django.views.defaults.server_error should use RequestContext

2006-09-22 Thread Afternoon
Ivan, you're right to note that I can supply my own view. I will do that. James, why are context processors not able to handle exceptions and fall back to basic output, i.e. return an empty dictionary? I don't mean to waste anyone's time with this, I should have looked harder for the previous di

Re: Re: Ticket #2773: django.views.defaults.server_error should use RequestContext

2006-09-21 Thread James Bennett
On 9/21/06, Afternoon <[EMAIL PROTECTED]> wrote: > At the same time middleware such as the session mechanics are still > invoked, performing complex actions. Why are these safer than the > context processors? In part because it depends on when the exception happens, and in part because middleware

Re: Ticket #2773: django.views.defaults.server_error should use RequestContext

2006-09-21 Thread Ivan Sagalaev
Afternoon wrote: > I disagree. For background, I have a context processor which simply > pushes a dictionary of standard items, such as URLBASE for media and > links, to all templates. It's very unlikely that an error will have > occurred which makes this a bad thing to do. Other people may have

Re: Ticket #2773: django.views.defaults.server_error should use RequestContext

2006-09-21 Thread Michael Radziej
Afternoon wrote: > Just a quick note to say I've added a ticket and patch to modify > django.views.defaults.server_error to use RequestContext instead of > Context, thus making context-processor-generated context available to > 500 pages. This was discussed ago and rejected because building

Re: Ticket #2773: django.views.defaults.server_error should use RequestContext

2006-09-21 Thread Afternoon
> 500 errors are bad; it's bail out time when they happen. I disagree. For background, I have a context processor which simply pushes a dictionary of standard items, such as URLBASE for media and links, to all templates. It's very unlikely that an error will have occurred which makes this a bad

Re: Ticket #2773: django.views.defaults.server_error should use RequestContext

2006-09-20 Thread Malcolm Tredinnick
On Thu, 2006-09-21 at 08:48 +1000, Malcolm Tredinnick wrote: > On Wed, 2006-09-20 at 22:48 +0100, Afternoon wrote: > > Just a quick note to say I've added a ticket and patch to modify > > django.views.defaults.server_error to use RequestContext instead of > > Context, thus making context-proce

Re: Ticket #2773: django.views.defaults.server_error should use RequestContext

2006-09-20 Thread Malcolm Tredinnick
On Wed, 2006-09-20 at 22:48 +0100, Afternoon wrote: > Just a quick note to say I've added a ticket and patch to modify > django.views.defaults.server_error to use RequestContext instead of > Context, thus making context-processor-generated context available to > 500 pages. Whilst I understa

Ticket #2773: django.views.defaults.server_error should use RequestContext

2006-09-20 Thread Afternoon
Just a quick note to say I've added a ticket and patch to modify django.views.defaults.server_error to use RequestContext instead of Context, thus making context-processor-generated context available to 500 pages. Ben --~--~-~--~~~---~--~~ You received this