OK. If the decision is made (forbid newlines in comments), then
newlines should be _really_ forbidden (currently not).
Opened a ticket for it - http://code.djangoproject.com/ticket/4171
On 27 апр, 00:46, "James Bennett" <[EMAIL PROTECTED]> wrote:
> On 4/26/07, tonnzor <[EMAIL PROTECTED]> wrote:
But then it should be at least mentioned in the documentation that
this tag works only on a single line and will cause unexpected
results when used on multiple lines (or better: raise an exception
when using multiple lines).
Thomas
On Apr 26, 2007, at 9:46 PM, James Bennett wrote:
>
> On
On 4/26/07, tonnzor <[EMAIL PROTECTED]> wrote:
> This feature is demanded and it is easy to implement w/o side effects.
> We should do it.
The ticket for this has been closed multiple times and Adrian has
asked that it not be reopened. Malcolm has asked that this thread be
allowed to die. That se
On Apr 26, 2007, at 4:40 PM, tonnzor wrote:
>
> This feature is demanded and it is easy to implement w/o side effects.
> We should do it.
+1
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups
"Django developers" g
> We already have multiline comments. They are written as {% comment %}
> and {% endcomment %}.
This inconveniently to use. Short variant {##} is much better and very
similar to C /* */.
> > So why can't we enable newlines for {##} only?
>
> This tag is parsed just as normal tags, so introducing
On Thu, 2007-04-26 at 14:12 +, tonnzor wrote:
> > > 2. If we want to enable multi-line comments, we need to allow newlines
> > > in tag's content:
> >
> > We don't want to allow newlines in tags. That decision has already been
> > made and reaffirmed a number of times.
>
> Comments are not ac
> > 2. If we want to enable multi-line comments, we need to allow newlines
> > in tag's content:
>
> We don't want to allow newlines in tags. That decision has already been
> made and reaffirmed a number of times.
Comments are not actually a tag, it's a special case. And it is very
useful to have
Thanks Michael, Ramiro, and David. I'll read up on the things you've
suggested.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups
"Django developers" group.
To post to this group, send email to django-developers@goog
On Wed, 2007-04-25 at 08:38 -0600, Lakin Wecker wrote:
>
> > 2. If we want to enable multi-line comments, we need to
> allow newlines
> > in tag's content:
>
> We don't want to allow newlines in tags. That decision has
> already been
> mad
Thanks Michael,
Now that you actually said it, I realize that this is the conclusion I've
been slowly coming too. Thanks for listening.
Lakin
On 4/25/07, Michael Radziej <[EMAIL PROTECTED]> wrote:
>
>
> On Wed, Apr 25, Lakin Wecker wrote:
>
> > I know that the devs probably don't want anyone to
> What tools do you use to manage your patched version?
I use svk for getting my patches updated and regenerated if changes
happened to the trunk and some lame gentoo-ebuild to install django
including my patches.
I pasted my ebuild here:
http://dpaste.com/hold/9042/
Some script to rebuild the
On 4/25/07, Andrew Durdin <[EMAIL PROTECTED]> wrote:
> I've been using a patched version of Django for some time, but it's
> highly inconvenient (I'm using a "vendor branch" strategy as described
> in the subversion book); so I'm looking for a different way to manage
> this sort of thing.
>
> Wha
On Wed, Apr 25, Andrew Durdin wrote:
>
> On Apr 25, 4:46 pm, Michael Radziej <[EMAIL PROTECTED]> wrote:
> >
> > My own patch stack currently comprises 22 patches ... and it's still ok and
> > quite manageable. I'm still up to date with svn.
>
> I've been using a patched version of Django for so
On Apr 25, 4:46 pm, Michael Radziej <[EMAIL PROTECTED]> wrote:
>
> My own patch stack currently comprises 22 patches ... and it's still ok and
> quite manageable. I'm still up to date with svn.
I've been using a patched version of Django for some time, but it's
highly inconvenient (I'm using a "v
On Wed, Apr 25, Lakin Wecker wrote:
> I know that the devs probably don't want anyone to bring this up again, so
> feel free to ignore me, but I really need to get this off my chest.
>
> I'm extremely frustrated by the newlines decision.
I understand you, but can only recommend what I usually
> > 2. If we want to enable multi-line comments, we need to allow newlines
> > in tag's content:
>
> We don't want to allow newlines in tags. That decision has already been
> made and reaffirmed a number of times.
I know that the devs probably don't want anyone to bring this up again, so
feel fre
On Mon, 2007-04-23 at 17:46 +, tonnzor wrote:
> I reviewed templates engine and found the problem. Here are the
> patches:
>
> 1. template.Lexer incorrectly recognizes ALL tokens - it check only
> the beginning of the token, ignoring the end of it.
>
[... code snipped ...]
Please put any pa
I reviewed templates engine and found the problem. Here are the
patches:
1. template.Lexer incorrectly recognizes ALL tokens - it check only
the beginning of the token, ignoring the end of it.
Example:
{{ my_var }} {{ other_var ## : variable other_var will be printed
Current code (template/__i
A patch, some docs and a few tests would be most welcome.
--Simon
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups
"Django developers" group.
To post to this group, send email to django-developers@googlegroups.com
+1 on this as well. Another reason to allow newlines inside tags.
Whitespace is whitespace is whitespace.
Lakin
On 4/12/07, Gabriel Farrell <[EMAIL PROTECTED]> wrote:
>
>
> On Apr 6, 3:31 pm, "Jonas Maurus" <[EMAIL PROTECTED]> wrote:
> >
> > If it can be changed, I'd also like to see only one co
On Apr 6, 3:31 pm, "Jonas Maurus" <[EMAIL PROTECTED]> wrote:
>
> If it can be changed, I'd also like to see only one comment style: {#
> [text] #} with the {##}-notation supportingmultiple-linecomments. {%
> comment %} can either get continued support or be deprecated.
>
> I don't agree with the c
tonnzor wrote:
> Yes, the comments are invalid, but in this case it should be ignored
> and printed as-is:
>
> Hello
> {# this
> comment
> has
> newlines #} World! some more text
This is a bug with the template lexer. Any token starting with open
tag text is incorrectly treated as a node of that
On Apr 6, 9:11 pm, "tonnzor" <[EMAIL PROTECTED]> wrote:
> Short templates comments {# #} are odd if used incorrectly - it eats
> text.
>
> This template (invalid comments):
>
> Hello
> {# this
> comment
> has
> newlines #} World! {{ "some more text" }}
>
> Now produce this output (text "World!" is
Short templates comments {# #} are odd if used incorrectly - it eats
text.
This template (invalid comments):
Hello
{# this
comment
has
newlines #} World! {{ "some more text" }}
Now produce this output (text "World!" is eaten):
Hello
some more text
Yes, the comments are invalid, but in this ca
24 matches
Mail list logo
