Re: Taming management.py, the 1730-line behemoth

2007-08-17 Thread Russell Keith-Magee
On 8/18/07, Russell Keith-Magee <[EMAIL PROTECTED]> wrote: > On 8/16/07, Jacob Kaplan-Moss <[EMAIL PROTECTED]> wrote: > > > > I'd like to suggest a (somewhat controversial) extension: > > > > Let any (installed) app provide its own manage.py actions in a similar > > way -- something like:: > > FYI

Re: Taming management.py, the 1730-line behemoth

2007-08-17 Thread Russell Keith-Magee
On 8/16/07, Jacob Kaplan-Moss <[EMAIL PROTECTED]> wrote: > > I'd like to suggest a (somewhat controversial) extension: > > Let any (installed) app provide its own manage.py actions in a similar > way -- something like:: FYI - I've committed this feature in [5923]. Yours, Russ Magee %-) --~--~--

Re: Taming management.py, the 1730-line behemoth

2007-08-16 Thread Adrian Holovaty
On 8/16/07, Russell Keith-Magee <[EMAIL PROTECTED]> wrote: > Have done; a few smallish changes leading up to [5903]. > > There were a few small bugs with missing imports; I've also added two > new base command types to improve error checking: Excellent -- thanks for making the good changes. Adri

Re: Taming management.py, the 1730-line behemoth

2007-08-16 Thread Russell Keith-Magee
On 8/16/07, Adrian Holovaty <[EMAIL PROTECTED]> wrote: > > Django committers Down > Under, feel free to chip in, if you'd like. Have done; a few smallish changes leading up to [5903]. There were a few small bugs with missing imports; I've also added two new base command types to improve error ch

Re: Taming management.py, the 1730-line behemoth

2007-08-16 Thread Vsevolod Solovyov
On 8/16/07, Adrian Holovaty <[EMAIL PROTECTED]> wrote: > As of changeset [5898], I've checked in this refactoring. manage.py startapp doesn't work after update. I've filled ticket http://code.djangoproject.com/ticket/5179 -- Vsevolod Solovyov --~--~-~--~~~---~--~--

RE: Taming management.py, the 1730-line behemoth

2007-08-16 Thread Michael Elsdoerfer
register commands as an alternative. Michael > -Original Message- > From: django-developers@googlegroups.com [mailto:django- > [EMAIL PROTECTED] On Behalf Of Marty Alchin > Sent: Thursday, August 16, 2007 1:35 AM > To: django-developers@googlegroups.com > Subject: Re: Ta

Re: Taming management.py, the 1730-line behemoth

2007-08-15 Thread limodou
On 8/16/07, Adrian Holovaty <[EMAIL PROTECTED]> wrote: > > On 8/15/07, Adrian Holovaty <[EMAIL PROTECTED]> wrote: > > In implementing the "manage.py testserver" command, I've been struck > > by how large django/core/management.py has gotten. It's 1730 lines > > long -- and messy. > > > > I'd like

Re: Taming management.py, the 1730-line behemoth

2007-08-15 Thread limodou
On 8/16/07, Adrian Holovaty <[EMAIL PROTECTED]> wrote: > > On 8/15/07, Jacob Kaplan-Moss <[EMAIL PROTECTED]> wrote: > > Sounds like a really good idea to me -- looking forward to it! > > Cool -- I'm on it. > > > I'd like to suggest a (somewhat controversial) extension: > > > > Let any (installed)

Re: Taming management.py, the 1730-line behemoth

2007-08-15 Thread Adrian Holovaty
On 8/15/07, Adrian Holovaty <[EMAIL PROTECTED]> wrote: > In implementing the "manage.py testserver" command, I've been struck > by how large django/core/management.py has gotten. It's 1730 lines > long -- and messy. > > I'd like to split this into several files, turning > django.core.management in

Re: Taming management.py, the 1730-line behemoth

2007-08-15 Thread Gary Wilson
Marty Alchin wrote: > On 8/15/07, Jacob Kaplan-Moss <[EMAIL PROTECTED]> wrote: >> This would let projects like S-E -- there's a reason I used it for the >> example -- provide custom management actions; installing said app >> would make those actions "appear" in manage.py. This would go a long >> w

Re: Taming management.py, the 1730-line behemoth

2007-08-15 Thread Jannis Leidel
On 15 Aug., 19:51, "Adrian Holovaty" <[EMAIL PROTECTED]> wrote: > I'd like to split this into several files, turning > django.core.management into a package. The purest way of splitting the > functionality would be to give each manage.py action ("runserver", > "syncdb", etc.) its own Python module

Re: Taming management.py, the 1730-line behemoth

2007-08-15 Thread Marty Alchin
On 8/15/07, Adrian Holovaty <[EMAIL PROTECTED]> wrote: > I think it would merely delay the bikeshed discussions. If we don't > have a required file layout, people will spend long mailing-list > threads five months from now talking about how *they* do things, and > how there should be an establishe

Re: Taming management.py, the 1730-line behemoth

2007-08-15 Thread Russell Keith-Magee
On 8/16/07, Jacob Kaplan-Moss <[EMAIL PROTECTED]> wrote: > > On 8/15/07, Adrian Holovaty <[EMAIL PROTECTED]> wrote: > > I'd like to split this into several files, turning > > django.core.management into a package. The purest way of splitting the > > functionality would be to give each manage.py ac

Re: Taming management.py, the 1730-line behemoth

2007-08-15 Thread Adrian Holovaty
On 8/15/07, Marty Alchin <[EMAIL PROTECTED]> wrote: > That's just my opinion, but it seems like it could avoid a lot of > bikeshed discussions where people debate the best file structure to > use. I think it would merely delay the bikeshed discussions. If we don't have a required file layout, peo

Re: Taming management.py, the 1730-line behemoth

2007-08-15 Thread Marty Alchin
On 8/15/07, Jacob Kaplan-Moss <[EMAIL PROTECTED]> wrote: > I'd like to suggest a (somewhat controversial) extension: > > Let any (installed) app provide its own manage.py actions in a similar > way -- something like:: > > schema_evolution/ > management/ > __init__.py >

Re: Taming management.py, the 1730-line behemoth

2007-08-15 Thread Brantley Harris
On 8/15/07, Jacob Kaplan-Moss <[EMAIL PROTECTED]> wrote: > Let any (installed) app provide its own manage.py actions in a similar > way -- something like: +1. As I was reading Adrian's post, I was thinking the very same thing. --~--~-~--~~~---~--~~ You received t

Re: Taming management.py, the 1730-line behemoth

2007-08-15 Thread SmileyChris
On Aug 16, 5:51 am, "Adrian Holovaty" <[EMAIL PROTECTED]> wrote: > This would be the extent of my refactoring for now. Any strong > thoughts either way before I go ahead and implement it? Sounds great! One other thing that would be nice is if the sql generation methods were refactored too so they

Re: Taming management.py, the 1730-line behemoth

2007-08-15 Thread Jacob Kaplan-Moss
On 8/15/07, George Vilches <[EMAIL PROTECTED]> wrote: > There aren't enough +1s in the world for me to vote as strongly as I > would like on both Adrian's initial proposal and this extension. That's just because I've been hoarding them. Once the bottom drops out of the subprime market I think the

Re: Taming management.py, the 1730-line behemoth

2007-08-15 Thread George Vilches
> I'd like to suggest a (somewhat controversial) extension: > > Let any (installed) app provide its own manage.py actions in a similar > way -- something like:: > > schema_evolution/ > management/ > __init__.py > commands/ > __init__.py >

Re: Taming management.py, the 1730-line behemoth

2007-08-15 Thread Adrian Holovaty
On 8/15/07, Jacob Kaplan-Moss <[EMAIL PROTECTED]> wrote: > Sounds like a really good idea to me -- looking forward to it! Cool -- I'm on it. > I'd like to suggest a (somewhat controversial) extension: > > Let any (installed) app provide its own manage.py actions in a similar > way -- something l

Re: Taming management.py, the 1730-line behemoth

2007-08-15 Thread Jacob Kaplan-Moss
On 8/15/07, Adrian Holovaty <[EMAIL PROTECTED]> wrote: > I'd like to split this into several files, turning > django.core.management into a package. The purest way of splitting the > functionality would be to give each manage.py action ("runserver", > "syncdb", etc.) its own Python module, like th

Re: Taming management.py, the 1730-line behemoth

2007-08-15 Thread Deryck Hodge
On 8/15/07, Deryck Hodge <[EMAIL PROTECTED]> wrote: > On 8/15/07, Adrian Holovaty <[EMAIL PROTECTED]> wrote: > > I'd like to split this into several files, turning > > django.core.management into a package. The purest way of splitting the > > functionality would be to give each manage.py action ("

Re: Taming management.py, the 1730-line behemoth

2007-08-15 Thread Deryck Hodge
On 8/15/07, Adrian Holovaty <[EMAIL PROTECTED]> wrote: > I'd like to split this into several files, turning > django.core.management into a package. The purest way of splitting the > functionality would be to give each manage.py action ("runserver", > "syncdb", etc.) its own Python module, like th

Re: Taming management.py, the 1730-line behemoth

2007-08-15 Thread Adrian Holovaty
On 8/15/07, Adrian Holovaty <[EMAIL PROTECTED]> wrote: > backends/ > __init__.py > runserver.py > sqlall.py > syncdb.py I wrote "backends" there, but I meant "commands", which would be a more meaningfu

Taming management.py, the 1730-line behemoth

2007-08-15 Thread Adrian Holovaty
In implementing the "manage.py testserver" command, I've been struck by how large django/core/management.py has gotten. It's 1730 lines long -- and messy. I'd like to split this into several files, turning django.core.management into a package. The purest way of splitting the functionality would