Re: Syndication Contrib and HTTP Not Modified

2007-03-08 Thread Jeremy Bowers
Malcolm Tredinnick wrote: > Cool. I'll have a look at it in detail. From a first read, though, it > looks like a reasonable approach: building in cache management to the > view. Why can't this be done using the normal CacheMiddleware, though? > I hadn't read the source on that; now I have. It's

Re: Syndication Contrib and HTTP Not Modified

2007-03-08 Thread James Bennett
On 3/8/07, Malcolm Tredinnick <[EMAIL PROTECTED]> wrote: > You may be unlucky here in who chose to respond. There's evidence to > suggest that I'm more of a hard-ass on this front than the other core > developers, but only by a little bit. Bah. Now I have to respond, because I've got a reputation

Re: Syndication Contrib and HTTP Not Modified

2007-03-08 Thread Malcolm Tredinnick
Hey Jeremy, On Thu, 2007-03-08 at 12:37 -0500, Jeremy Bowers wrote: > Malcolm Tredinnick wrote: > > For concreteness, I've added a ticket and there is a code-only patch at > http://code.djangoproject.com/attachment/ticket/3680/cache.control.on.syndication.code.only.diff > > . The patch is exc

Re: Syndication Contrib and HTTP Not Modified

2007-03-08 Thread Jeremy Bowers
Malcolm Tredinnick wrote: For concreteness, I've added a ticket and there is a code-only patch at http://code.djangoproject.com/attachment/ticket/3680/cache.control.on.syndication.code.only.diff . The patch is exceedingly lightly tested (I've only smoke tested it on a local dev box, and I hav

Re: Syndication Contrib and HTTP Not Modified

2007-03-07 Thread Malcolm Tredinnick
On Thu, 2007-03-08 at 01:33 -0500, Jeremy Bowers wrote: > Malcolm Tredinnick wrote: > > Since we already have middleware for attaching ETags (CommonMiddleware) > > and supporting conditional GETs (ConditionalGetMiddleware), it would be > > nice to work out why they aren't just doing the right thin

Re: Syndication Contrib and HTTP Not Modified

2007-03-07 Thread Jeremy Bowers
Malcolm Tredinnick wrote: > Since we already have middleware for attaching ETags (CommonMiddleware) > and supporting conditional GETs (ConditionalGetMiddleware), it would be > nice to work out why they aren't just doing the right thing here. I found ConditionalGetMiddleware before I wrote my extra

Re: Syndication Contrib and HTTP Not Modified

2007-03-07 Thread Malcolm Tredinnick
On Wed, 2007-03-07 at 23:04 -0500, Jeremy Bowers wrote: > Unless I'm missing something, the syndication framework does not have > the ability to return HTTP 304 in response to unchanged feeds. This is bad. > > I've worked up a solution locally which I'd like to get feedback on, and > a couple q

Syndication Contrib and HTTP Not Modified

2007-03-07 Thread Jeremy Bowers
Unless I'm missing something, the syndication framework does not have the ability to return HTTP 304 in response to unchanged feeds. This is bad. I've worked up a solution locally which I'd like to get feedback on, and a couple questions. Currently, I've got this: * The feed class is slightly