Re: Support for unittest -k option

2019-03-13 Thread Luke Plant
I use `--keepdb` a lot, I never knew there was a shorthand and even know I do know wouldn't use it. For things like this I usually find it easy to remember the long option. So I'm +1 on changing it too, without a new shorthand for `--keepdb`. In the keyword usage

Re: Support for unittest -k option

2019-03-11 Thread Arthur Rio
I’m +1 on no short-hand. Also “kdb” is a little to close to “pdb” and doesn’t really make sense to me. — Arthur On March 11, 2019 at 3:33:50 PM, Dan Davis (dansm...@gmail.com) wrote: I personally don't think a short-hand is needed. On Mon, Mar 11, 2019 at 10:41 AM Tim Graham wrote: > -kdb cou

Re: Support for unittest -k option

2019-03-11 Thread Dan Davis
I personally don't think a short-hand is needed. On Mon, Mar 11, 2019 at 10:41 AM Tim Graham wrote: > -kdb could be a suitable short option. > > On Monday, March 11, 2019 at 9:20:37 AM UTC-4, Tobias McNulty wrote: >> >> Agreed it's probably better to make the switch now, and I'd be fine >> witho

Re: Support for unittest -k option

2019-03-11 Thread Tim Graham
-kdb could be a suitable short option. On Monday, March 11, 2019 at 9:20:37 AM UTC-4, Tobias McNulty wrote: > > Agreed it's probably better to make the switch now, and I'd be fine > without a replacement shorthand alternative for --keepdb. > > Cheers, > > > *Tobias McNulty*Chief Executive Officer

Re: Support for unittest -k option

2019-03-11 Thread Tobias McNulty
Agreed it's probably better to make the switch now, and I'd be fine without a replacement shorthand alternative for --keepdb. Cheers, *Tobias McNulty*Chief Executive Officer tob...@caktusgroup.com www.caktusgroup.com On Mon, Mar 11, 2019 at 8:19 AM Carlton Gibson wrote: > Thanks François, >

Re: Support for unittest -k option

2019-03-11 Thread Adam Johnson
+1 from me, I'm okay with the small breaking change to keep in-line with upstream unittest. Since it's restricted to tests, it's unlikely to break anyone's production site. On Mon, 11 Mar 2019 at 12:19, Carlton Gibson wrote: > Thanks François, > > Just on this, my thought is that if we don't fol

Re: Support for unittest -k option

2019-03-11 Thread Carlton Gibson
Thanks François, Just on this, my thought is that if we don't follow `unittest` in changing `-k` for this, we have a steady trickle of confusion forever-more. I'd rather avoid that. C. On Monday, 11 March 2019 13:14:01 UTC+1, François Freitag wrote: > > Hi Django Devs, > > https://code.djang

Support for unittest -k option

2019-03-11 Thread François Freitag
Hi Django Devs, https://code.djangoproject.com/ticket/30245 suggests supporting Python unittest `-k` option, to selectively run tests matching a keyword. Currently, `-k` is the shorthand for `--keepdb` in Django. A `--filter` flag was suggested to preserve backward compatibility. Carlton suggeste