Re: Split DeleteView into a more generic ConfirmView

2015-12-11 Thread Marc Tamlyn
No problem - I mentioned this thread on twitter to one of the braces devs and he also likes your idea. https://twitter.com/kennethlove/status/674237007439073280 On 10 December 2015 at 23:52, Lennart Buit wrote: > Hello Marc, > > Thanks for your response, I will change my proposal to target > dja

Re: Split DeleteView into a more generic ConfirmView

2015-12-10 Thread Lennart Buit
Hello Marc, Thanks for your response, I will change my proposal to target django-braces. Will take me a few days tho, because I am loaded with (school) work right now :). --Lennart On Tuesday, December 8, 2015 at 10:38:01 AM UTC+1, Marc Tamlyn wrote: > > Hi Lennart, > > I certainly like the id

Re: Split DeleteView into a more generic ConfirmView

2015-12-08 Thread Marc Tamlyn
Hi Lennart, I certainly like the idea and have written at least two implementations of `ConfirmView` in my projects before. Without getting into specifics, I'm not sure how we feel about adding more generic views like this, even where it does make sense. To me a good initial course of action could

Re: Split DeleteView into a more generic ConfirmView

2015-12-07 Thread Lennart Buit
I should add patches that I promise to add ;) --Lennart On Monday, December 7, 2015 at 9:23:19 PM UTC+1, Lennart Buit wrote: > > Hey all, > > One of my minor annoyances with the class based view system in django is > that there is no clear way to model a confirmable action. The concept does > e

Split DeleteView into a more generic ConfirmView

2015-12-07 Thread Lennart Buit
Hey all, One of my minor annoyances with the class based view system in django is that there is no clear way to model a confirmable action. The concept does exists in cbv, but only for deleting objects. I however think that there are more usages for confirming actions other then delete. Lets l