Re: Skip session save on 500 responses

2012-07-09 Thread Luke Plant
On 09/07/12 20:07, Anssi Kääriäinen wrote: > I have updated the branch [https://github.com/akaariai/django/tree/ > ticket_3881], I think it now has all the necessary doc changes. If > somebody is kind enough to double-check the patch, that would be > great. If that somebody is a committer, committ

Re: Skip session save on 500 responses

2012-07-09 Thread Anssi Kääriäinen
On 9 heinä, 19:59, Don Spaulding wrote: > On Saturday, July 7, 2012 3:46:14 AM UTC-5, Florian Apolloner wrote: > > > On Friday, July 6, 2012 12:02:56 AM UTC+2, Luke Plant wrote: > > >> I agree it should be changed, and I would regard it as a bug fix, but > >> make a note of it in the 1.5 release n

Re: Skip session save on 500 responses

2012-07-09 Thread Don Spaulding
On Saturday, July 7, 2012 3:46:14 AM UTC-5, Florian Apolloner wrote: > > On Friday, July 6, 2012 12:02:56 AM UTC+2, Luke Plant wrote: >> >> I agree it should be changed, and I would regard it as a bug fix, but >> make a note of it in the 1.5 release notes nonetheless. >> > > +1 > > Cheers, > Flor

Re: Skip session save on 500 responses

2012-07-07 Thread Florian Apolloner
On Friday, July 6, 2012 12:02:56 AM UTC+2, Luke Plant wrote: > > I agree it should be changed, and I would regard it as a bug fix, but > make a note of it in the 1.5 release notes nonetheless. > +1 Cheers, Florian -- You received this message because you are subscribed to the Google Groups

Re: Skip session save on 500 responses

2012-07-05 Thread Luke Plant
On 05/07/12 16:25, Anssi Kääriäinen wrote: > Currently Django's session middleware saves sessions unconditionally > in process_response. I have created a patch which skips session save > on 500 responses. Reasons for this: > 1. When saving the session after PostgreSQL query error into database > b

Skip session save on 500 responses

2012-07-05 Thread Anssi Kääriäinen
Currently Django's session middleware saves sessions unconditionally in process_response. I have created a patch which skips session save on 500 responses. Reasons for this: 1. When saving the session after PostgreSQL query error into database backed session store, the save is guaranteed to fail d