Re: Review of DEP 201 - simplified routing syntax

2017-05-23 Thread Chris Foresman
Huzzah! Looking forward to the new syntax landing. On Sunday, May 21, 2017 at 2:56:13 AM UTC-5, Aymeric Augustin wrote: > > Hello, > > The technical board accepted DEP 201: > https://github.com/django/deps/blob/master/accepted/0201-simplified-routing-syntax.rst > > Sjoerd has taken the lead on t

Re: Review of DEP 201 - simplified routing syntax

2017-05-21 Thread Aymeric Augustin
Hello, The technical board accepted DEP 201: https://github.com/django/deps/blob/master/accepted/0201-simplified-routing-syntax.rst Sjoerd has taken the lead on the implementation, please get in touch if y

Re: Review of DEP 201 - simplified routing syntax

2017-05-14 Thread Sjoerd Job Postmus
Thinking about it some more: that is not the solution. Also, there are probably a couple of corner cases to consider (still: the same as for normal regular expressions): * What if the "keys" (named parameters) of a translated path differs from that of the original path? * What if the converters

Re: Review of DEP 201 - simplified routing syntax

2017-05-13 Thread Sjoerd Job Postmus
On Saturday, May 13, 2017 at 1:35:37 PM UTC+2, Marten Kenbeek wrote: > > The regex in `url()` can be translated > > > using `ugettext_lazy()`, in which case the lazy translation happens when > `resolve()

Re: Review of DEP 201 - simplified routing syntax

2017-05-13 Thread Marten Kenbeek
The regex in `url()` can be translated using `ugettext_lazy()`, in which case the lazy translation happens when `resolve()` or `reverse()` is called. It seems the current `path()` implementation would for

Re: Review of DEP 201 - simplified routing syntax

2017-05-12 Thread Aymeric Augustin
> On 12 May 2017, at 19:05, Marten Kenbeek wrote: > > That's not quite right. Django has actually been using the `re.UNICODE` flag > since at least 1.0, so you'd have the same problem on Python 2. Since 1.0 exactly; this behavior was introduced in https://github.com/django/django/commit/8c85d

Re: Review of DEP 201 - simplified routing syntax

2017-05-12 Thread Marten Kenbeek
On Friday, May 12, 2017 at 6:43:34 PM UTC+2, Florian Apolloner wrote: > > > > On Friday, May 12, 2017 at 12:33:28 PM UTC+2, Aymeric Augustin wrote: >> >> Django's URL resolver matches URLs as str (Unicode strings), not bytes, >> after percent and UTF-8 decoding. As a consequence \d matches any >>

Re: Review of DEP 201 - simplified routing syntax

2017-05-12 Thread Florian Apolloner
On Friday, May 12, 2017 at 12:33:28 PM UTC+2, Aymeric Augustin wrote: > > Django's URL resolver matches URLs as str (Unicode strings), not bytes, > after percent and UTF-8 decoding. As a consequence \d matches any > character in Unicode character category Nd >

Re: Review of DEP 201 - simplified routing syntax

2017-05-12 Thread Aymeric Augustin
After getting approval from Tom on IRC, I updated the DEP according to my email below: https://github.com/django/deps/pull/41 The next steps are: - account for any remaining feedback (I feel I made only minor changes compared to the last version, hopefu

Review of DEP 201 - simplified routing syntax

2017-05-12 Thread Aymeric Augustin
Hello, I reviewed the current version of DEP 201 as well as related discussions