Re: Review needed: Proposed behavior change in Field.contribute_to_class()

2020-03-12 Thread Mariusz Felisiak
+1 from me. Best, Mariusz -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group. To unsubscribe from this group and stop receiving emails from it, send an email to django-developers+unsubscr...@googlegroups.com.

Re: Review needed: Proposed behavior change in Field.contribute_to_class()

2020-03-04 Thread Adam Johnson
+1 from me Afraid I don't know any of the why. Also worth noting from the PR description: Previously: DeferredAttributes would not get stapled onto models where the > model (or an ancestor) already had an existing *non-falsey* attribute. > Non-falsey! I almost spat out my tea. Thanks for the d

Review needed: Proposed behavior change in Field.contribute_to_class()

2020-03-04 Thread Carlton Gibson
Hi all. Especially from those with long memories, can I request thoughts on a proposed adjustment to `Field.contribute_to_class()`, which affects the manner in which fields override attributes from parent classes? The entails a breaking change. As such... 😬 — but I think it's acceptable and wo