Re: Rev 6164 breaks HTTPS redirects

2007-09-26 Thread Jeffrey Froman
I see the new ticket in Trac: http://code.djangoproject.com/ticket/5604 Thanks very much for creating the ticket, and submitting the patch. Jeffrey --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "Django develope

Re: Rev 6164 breaks HTTPS redirects

2007-09-25 Thread Jeffrey Froman
On Sep 25, 7:12 am, "Ramiro Morales" <[EMAIL PROTECTED]> wrote: > Jeffrey, can you test that patch on your enviroment and report back > if it solves the problem so a ticket+patch can be created on Django Trac?. I have tested this fix, and it appears to work perfectly here, passing all redirectio

Re: Rev 6164 breaks HTTPS redirects

2007-09-25 Thread Ramiro Morales
On 9/24/07, Ramiro Morales <[EMAIL PROTECTED]> wrote: > > Fortunately this is being handled by an abstraction in the form of a > is_secure() > method on the Django handler classes on django.core.handlers. > Perhaps a patch like this would solve Jeffrey problems?: > > --- a/django/core/handlers/w

Re: Rev 6164 breaks HTTPS redirects

2007-09-24 Thread Ramiro Morales
On 9/24/07, Graham Dumpleton <[EMAIL PROTECTED]> wrote: > > In WSGI indication of https is specified by: > > wsgi.url_scheme A string representing the "scheme" portion of the URL > at which the application is being invoked. Normally, this will have > the value "http" or "https", as appropr

Re: Rev 6164 breaks HTTPS redirects

2007-09-24 Thread Graham Dumpleton
On Sep 25, 3:54 am, Jeffrey Froman <[EMAIL PROTECTED]> wrote: > Hello, > > As of revision #6164, when accessing my site over HTTPS, all redirects > are being sent to plain HTTP urls. > > It seems that this is because build_absolute_uri() uses > request.is_secure() to determine if the absolute ur

Rev 6164 breaks HTTPS redirects

2007-09-24 Thread Jeffrey Froman
Hello, As of revision #6164, when accessing my site over HTTPS, all redirects are being sent to plain HTTP urls. It seems that this is because build_absolute_uri() uses request.is_secure() to determine if the absolute url should be secure, and request.is_secure() makes its determination based on