Re: Status of 3.2 release blockers.

2021-01-13 Thread Adam Johnson
I would also lean towards option 3. If someone makes wrappers they might also release them in a third party package. On Wed, 13 Jan 2021 at 17:46, Carlton Gibson wrote: > Hi Paul, > > Thanks for this follow up. To give context, I think there’s enough support > (here and on the PR) to say, OK let

Re: Status of 3.2 release blockers.

2021-01-13 Thread Carlton Gibson
Hi Paul, Thanks for this follow up. To give context, I think there’s enough support (here and on the PR) to say, OK let’s take it. Mariusz and I have two others on the list, which we’ll get in tomorrow. I’ll then branch stable/3.2.x (and we can bootstrap Django 4.0 and continue main line developm

Re: Status of 3.2 release blockers.

2021-01-13 Thread Paul Ganssle
As we come closer to the deadline, I thought I'd like to bring attention to the one aspect of the zoneinfo-support PR that I am least certain about but which hasn't gotten much discussion, detailed here: https://github.com/django/django/pull/13877#issuecomment-758769902 *Note*: I don't think anyth

Re: Status of 3.2 release blockers.

2021-01-12 Thread Paolo Melchiorre
I agree with Adam. I've also left a small comment on the PR. Paolo On Tue, Jan 12, 2021 at 5:59 PM Adam Johnson wrote: > > I think it's worth merging into 3.2. The change is quite small, the potential > benefits are quite large, and some users live LTS to LTS so could be left > without an opt

Re: Status of 3.2 release blockers.

2021-01-12 Thread Adam Johnson
I think it's worth merging into 3.2. The change is quite small, the potential benefits are quite large, and some users live LTS to LTS so could be left without an option for a long time. I've left some review comments on the PR. On Tue, 12 Jan 2021 at 15:29, Paul Ganssle wrote: > Yeah, sorry I

Re: Status of 3.2 release blockers.

2021-01-12 Thread Paul Ganssle
Yeah, sorry I didn't get around to this until so close to the deadline. December was a lot crazier for me than I had hoped. ☹ One thing I'll note is that this PR to allow using zoneinfo timezones is /mostly/ just adding tests. The substantive changes to the codebase are very light, and there shoul

Re: Status of 3.2 release blockers.

2021-01-12 Thread Carlton Gibson
Hi all. Paul Ganssle has followed up his earlier PoC PR, and the previous discussion , with a smaller PR in order to *allow* using zoneinfo timezones without an error: Add support for non-pytz zones https://github.com/django/django/p

Re: Status of 3.2 release blockers.

2021-01-06 Thread Carlton Gibson
TBH I see Adam has given it the All clear. There should be some way that enough of that adds up to it just getting merged (but I REALLY don't have capacity to think about THAT this week 😀) It's on the list. On Wednesday, 6 January 2021 at 16:46:37 UTC+1 Carlton Gibson wrote: > Hey Nick. > >

Re: Status of 3.2 release blockers.

2021-01-06 Thread Carlton Gibson
Hey Nick. Yes, good. 😀 Issue is capacity to look at it. If I can get there I will. Kind Regards, Carlton On Wednesday, 6 January 2021 at 16:01:15 UTC+1 Nick Pope wrote: > Hi Carlton, > > Just wondering if you're still willing to accept the following for 3.2: > >- https://code.djangopro

Re: Status of 3.2 release blockers.

2021-01-06 Thread Nick Pope
Hi Carlton, Just wondering if you're still willing to accept the following for 3.2: - https://code.djangoproject.com/ticket/16117 - https://github.com/django/django/pull/13532 Adam marked it "ready for checkin" about 6 weeks ago. Cheers, Nick On Wednesday, 6 January 2021 at 10:04:18

Re: Status of 3.2 release blockers.

2021-01-06 Thread Carlton Gibson
Hey Florian. OK +1, no problem. > Let me know if I can help somewhere else in exchange ;) Super. On Wednesday, 6 January 2021 at 10:31:54 UTC+1 f.apo...@gmail.com wrote: > Hi Carlton, > > I'd like to put > https://github.com/django/django/pull/12553 > https://github.com/django/django/pull/

Re: Status of 3.2 release blockers.

2021-01-06 Thread Florian Apolloner
Hi Carlton, I'd like to put https://github.com/django/django/pull/12553 https://github.com/django/django/pull/13800 onto this list as well. They are imo basically finished and I'd love reviews from our fellows. Let me know if I can help somewhere else in exchange ;) Cheers, Florian On Monday