Re: Proposed change in ORM model save logic

2021-10-20 Thread 'Adam Johnson' via Django developers (Contributions to Django itself)
I am also in favour. Thanks for explaining Barry. On Mon, 18 Oct 2021 at 11:22, Carlton Gibson wrote: > OK, thanks all, let's reopen. These kind of wontfix+MailingList issues is > more about getting more eyes on it than anything else, and the explanation > you've given is super Barry. > > C. > O

Re: Proposed change in ORM model save logic

2021-10-18 Thread Carlton Gibson
OK, thanks all, let's reopen. These kind of wontfix+MailingList issues is more about getting more eyes on it than anything else, and the explanation you've given is super Barry. C. On Sunday, 17 October 2021 at 09:59:18 UTC+2 Aymeric Augustin wrote: > Hello, > > On 15 Oct 2021, at 08:49, Barr

Re: Proposed change in ORM model save logic

2021-10-17 Thread Aymeric Augustin
Hello, > On 15 Oct 2021, at 08:49, Barry Johnson wrote: > > Instead of resolving this difference in keys by executing: > setattr(self, field.attname, obj.pk) > We believe it should instead: > setattr(self, field.name, obj) For anyone reading this, this code is https://github.com/django

Re: Proposed change in ORM model save logic

2021-10-16 Thread Barry Johnson
On Friday, October 15, 2021 at 12:39:52 PM UTC-5 pyt...@ian.feete.org wrote: > You set out a good case, it's much easier to understand the "why" here than in the original ticket. Yes. It was hard to compress the matter down small enough to reasonably fit in a Trac entry, so skipped the vast ma

Re: Proposed change in ORM model save logic

2021-10-15 Thread Ian Foote
Hi Barry, Based on this I'm cautiously in favour. You set out a good case, it's much easier to understand the "why" here than in the original ticket. I'd avoid the extra optimisation of accessing __dict__ directly though - if __set__ gains extra functionality, I'd prefer not to accidentally miss