Re: Proposal: Permit __file__-less migrations packages

2020-12-28 Thread William Schwartz
In the hope that I have allayed this group's initial concerns, I have created ticket #32302 and pull request GH-13820 . If you still have reservations, I am happy to discuss this matter further. Getting t

Re: Proposal: Permit __file__-less migrations packages

2020-12-22 Thread William Schwartz
Mariusz, Thanks for your response! *> I have the impression that more changes are needed to support "freezers" Are we sure this is the only change that is needed?* Django will indeed require changes beyond today's proposal for full freezer support. I am pursuing an incremental approach her

Re: Proposal: Permit __file__-less migrations packages

2020-12-22 Thread Mariusz Felisiak
Hi, Thanks for extra details. It's not about the number of LOC. I have the impression that more changes are needed to support "freezers" , see the previous discussion about PyOxidizer . Are we sure this is the only

Re: Proposal: Permit __file__-less migrations packages

2020-12-22 Thread William Schwartz
I now see that my original post was too vague. I will more thoroughly explain myself below, including the actual patch (because it's that short!). *My proposal will not change Django's behavior at all for anyone not using "freezers" *such as PyOxidizer, cx_Freeze, Nuitka, PyInstaller, and the l

Re: Proposal: Permit __file__-less migrations packages

2020-12-22 Thread Mariusz Felisiak
Hi, I can only repeat my arguments from the ticket. I don't see a strong reason to add an extra dependency for this. Django 4.0 will drop support for Python 3.6 and Python 3.7, so we can reconsider this ticket when developing Django 4

Re: Proposal: Permit __file__-less migrations packages

2020-12-22 Thread William Schwartz
As I said in my original post, I *do not propose to change the behavior of Django with respect to namespace packages*. My proposal only makes the check for them more specific so that we permit *regular* packages run from Python environments that do not set __file__. On Tuesday, December 22, 202

Re: Proposal: Permit __file__-less migrations packages

2020-12-22 Thread Adam Johnson
I've hit several problems with PEP-420 namespace packages in the last few months, which inspired me to create flake8-no-pep420: https://pypi.org/project/flake8-no-pep420/ . In summary, I found pep-420 namespace packages are not checked by Django's test runner, coverage.py, or mypy (with its bonus f