Re: Multiple instances of DjangoAdmin share the same model LogEntry

2023-01-28 Thread Jacob Rief
Hi Adam, I'm currently preparing a pull request on this. No changes will be made to the model LogEntry. It will just allow implementers to filter log entries by registered models (of that instantiated admin). Not doing this, in my opinion is unexpected behaviour anyway. Thanks to Carlton for poin

Re: Multiple instances of DjangoAdmin share the same model LogEntry

2023-01-27 Thread 'Adam Johnson' via Django developers (Contributions to Django itself)
I'm also skeptical we need to support this use case. Certainly some users prefer *shared* log messages, so all actions are shown regardless of which interface was used. Just to comment on the DB side: storing the same few names over and over in such a column would be a waste of disk space. It woul

Re: Multiple instances of DjangoAdmin share the same model LogEntry

2023-01-26 Thread Carlton Gibson
Hey Jacob. I had in mind literally **just** adding the content-types so that the line in that render call would be: # this could be via a proposed context["site_content_types"] or via a map from # "available_apps" site_content_types: [ContentType] = ... entries = LogEntry.objects.

Re: Multiple instances of DjangoAdmin share the same model LogEntry

2023-01-26 Thread Jacob Rief
Hi Carlton, that proposal makes a lot of sense. This means that one could for instance add a custom function to that context which, if set, would be called by the AdminLogNode.render method and then overrides the context[self.varname]. How would you name that extra context variable, maybe "rende

Re: Multiple instances of DjangoAdmin share the same model LogEntry

2023-01-26 Thread Carlton Gibson
Thanks for clarifying Jacob, great. So, the registered content_types are in the available_apps key to the context passed to that tag. (Currently that needs reconstructing in a filter/comprehension, but it could feasibly be added to the `AdminSite.each_context` method.) Adding the matching `__in` l

Re: Multiple instances of DjangoAdmin share the same model LogEntry

2023-01-26 Thread Jacob Rief
Hi Carlton, As I understand it, separate admin sites may register different models, but I'm only going to see the History for instances that are visible to the current admin no? The Django admin interface uses a templatetag named get_admin_log. It renders the content of all entries of model L

Re: Multiple instances of DjangoAdmin share the same model LogEntry

2023-01-25 Thread Carlton Gibson
Hi Jacob. Can I ask you to explain your use-case a little more please? As I understand it, separate admin sites may register different models, but I'm only going to see the History for instances that are visible to the current admin no? Maybe you mean the Recent actions > My actions bit of the ind