Re: Mechanics of the EmailValidator.domain_allowlist rename.

2020-06-18 Thread Carlton Gibson
OK, thanks both — perhaps we're worrying too much. > For example, the get_query_set -> get_queryset rename... I'd managed to suppress that memory. 😀 C. On Thursday, 18 June 2020 19:05:54 UTC+2, Adam Johnson wrote: > > I also lean towards #1. > > I doubt many third party packages use the argum

Re: Mechanics of the EmailValidator.domain_allowlist rename.

2020-06-18 Thread Adam Johnson
I also lean towards #1. I doubt many third party packages use the argument since it seems quite site specific. I scrolled through 5 random-ish pages of github code search for "domain_whitelist" in python files and found nothing that looked like a django related usage. On Thu, 18 Jun 2020 at 16:42

Re: Mechanics of the EmailValidator.domain_allowlist rename.

2020-06-18 Thread Matthias Kestenholz
Hi I have survived a few changes in Django over the last >10 years, and this change is absolutely not comparable to any of the problematic ones. For example, the get_query_set -> get_queryset rename was hard because it was unclear how to properly support subclassing querysets. The on_delete addi