Re: ManytoMany Field save_form_data has not support for through table

2018-01-21 Thread Andrew Standley
Hey Collin, I posted a new PR: https://github.com/django/django/pull/9609 Let me know what your thoughts are. I also updated the ticket. Cheers, Andrew On Thursday, January 18, 2018 at 6:57:06 AM UTC-8, Collin Anderson wrote: > > Hi Andrew, > > Sure, do you want propose some tests? You cou

Re: ManytoMany Field save_form_data has not support for through table

2018-01-18 Thread Collin Anderson
Hi Andrew, Sure, do you want propose some tests? You could even open a new PR. Thanks, Collin 574-339-1060 On Thu, Jan 18, 2018 at 12:40 AM, Andrew Standley wrote: > Hi Collin, > The patch seems to work perfectly with intermediate models without > required fields. > > However looking over t

Re: ManytoMany Field save_form_data has not support for through table

2018-01-18 Thread Andrew Standley
Hi Collin, The patch seems to work perfectly with intermediate models without required fields. However looking over the pull request I noticed that there does not appears to be success tests for intermediate models with extra required fields. Is this something I could help out with? Cheers,

Re: ManytoMany Field save_form_data has not support for through table

2018-01-16 Thread Andrew Standley
Hi Collin,     Thanks, that would indeed help in my case. The save_form_data method of the ManyToMany field would still eventually need to be updated to have the ability to pass the through_defaults kwarg to set(). However none of the extra fields on my intermediate model are required so that

Re: ManytoMany Field save_form_data has not support for through table

2018-01-16 Thread Collin Anderson
Hi Andrew, Would allowing set() for through models help in your case? https://github.com/django/django/pull/8981 Thanks, Collin On Mon, Jan 15, 2018 at 5:14 PM, Andrew Standley < astand...@linear-systems.com> wrote: > Greetings, > I've been messing around with trying to update some custom