Re: GitHub Actions

Sorry for bumping such an old thread, but I've created a github actions POC and written it up here: https://forum.djangoproject.com/t/improving-the-contribution-experience-with-github-actions/5964 On Monday, 11 November 2019 at 08:11:57 UTC Johannes Maron wrote: > Hi Mariusz, > > Cool, let me

Re: GitHub Actions

Hi Mariusz, Cool, let me know if you have any questions about the config file that I wrote. I am happy to help :) Regarding the output, yes I can feel you. However I don’t know if we really need to run tests at verbosity level 2 on CI. One can always do that online or enable it if need be. At

Re: GitHub Actions

> I would suggest to open a PR to GitHub now and to get the Fellows > involved. Ask them how to best integrate a trial without disturbing their > workflow. What do you guys think? > > I'm going to play with GitHub actions in this week (or in the next one) but I'm still not convinced. It's fine

Re: GitHub Actions

I have some really good news! I managed to almost map our entire Jenkins suite to GitHub actions, except Oracle. Check out the output of the entire suite here. And the config here: .github/workflows/ci.yml Furthermore, I followed Tom’s great advice and switched everything to services. The execu

Re: GitHub Actions

No there isn’t. Right now Docker-box is optimized for local development and exists outside of the main repository, and for now I’d suggest not trying to integrate it. That can be some future work though! Regarding services vs apt, docker services is the only realistic way to do it. We cannot re

Re: GitHub Actions

> Then why not use all the work already done in django-docker-box there? Then >this would be "Run Django CI with Docker in the Azure cloud via Github Actions >instead of Jenkins via the Jenkins-Github integration (plugin?)” @Matematica that sounds promising is there a PR for that, that I have mi

Re: GitHub Actions

On Thu, Nov 7, 2019 at 10:12 PM Johannes Hoppe wrote: > @Tom, I stared to adapt some of your suggestions. Not done yet, I need to > wait for more log output from PostgeSQL to identify why it's stuck. > > I'll put in more work later today (UTC+9). I'll also open up a > pull-request somewhere to al

Re: GitHub Actions

@Tom, I stared to adapt some of your suggestions. Not done yet, I need to wait for more log output from PostgeSQL to identify why it's stuck. I'll put in more work later today (UTC+9). I'll also open up a pull-request somewhere to allow line wise comments and suggestions. @Matematica, good points

Re: GitHub Actions

Good idea Carlton, here you go https://code.djangoproject.com/ticket/30964#ticket On Friday, November 8, 2019 at 3:03:58 AM UTC+9, Carlton Gibson wrote: > > Please open an issue for the macOS failure. It’s been passing for me all > week so... 🤔 > > On Thu, 7 Nov 2019 at 17:31, Johannes Hoppe >

Re: GitHub Actions

On Thu, Nov 7, 2019 at 11:31 AM Johannes Hoppe wrote: > Hey Tom, > > Good to hear for you and very good points. I'll leave you a couple of > inline comments: > > On Friday, November 8, 2019 at 1:04:50 AM UTC+9, Tom Forbes wrote: >> >> This is fantastic! Thank you Johannes! Regarding sqlite MacOS

Re: GitHub Actions

Please open an issue for the macOS failure. It’s been passing for me all week so... 🤔 On Thu, 7 Nov 2019 at 17:31, Johannes Hoppe wrote: > Hey Tom, > > Good to hear for you and very good points. I'll leave you a couple of > inline comments: > > On Friday, November 8, 2019 at 1:04:50 AM UTC+9, To

Re: GitHub Actions

Hey Tom, Good to hear for you and very good points. I'll leave you a couple of inline comments: On Friday, November 8, 2019 at 1:04:50 AM UTC+9, Tom Forbes wrote: > > This is fantastic! Thank you Johannes! Regarding sqlite MacOS and Windows > tests, this is historical AFAIK (we don’t have the r

Re: GitHub Actions

This is fantastic! Thank you Johannes! Regarding sqlite MacOS and Windows tests, this is historical AFAIK (we don’t have the resources). With this we should test MacOS and Windows as part of the Sqlite matrix (i.e all python versions). A few notes: 1. We need to change the test runner output t

Re: GitHub Actions

Ok, I have one more insight. I added all databases (except Oracle) and altered the job matrix to reflect the current setup (why don't we test on macOS again?) Results can be found here: https://github.com/codingjoe/django/commit/386f5eb04dc0ae9424bcb1e1198ed7752cd9c10c/checks?check_suite_id=3003

Re: GitHub Actions

I put in a little effort and tried a couple of conceptual things. 1. YAML anchors, inheritance and includes are not yet supported by GitHub actions. 2. You can build dependent builds, or build stages, but you will need to keep everything in one file. (This gets messy without anchors & co). 3. You

Re: GitHub Actions

@Florian, dependent builds or build stages are possible, seealso:  https://github.com/codingjoe/django/commit/eeefc83a85ba5e91b98c4e29fb9b20896612cc8c/checks?check_suite_id=299641652 -- Johannes Hoppe www.johanneshoppe.com Want to chat? Let's get a coffee! https://calendly.com/codingjoe/call Le

Re: GitHub Actions

Wow, the response has been much bigger than expected. That's great, it's good to know that this is a topic people are invested in. It shows me two things: 1. There is a certain degree of dissatisfaction about the current setup. 2. There is enough interest to support a more community driven approa

Re: GitHub Actions

Maybe this discussion is slightly off topic, and at the risk of derailing things I’d like to put out my view on this. There is more to it than just “using Github’s computing power”, just as there is more to using AWS than “using Amazon’s computing power”. That’s only a small part of it: it’s al

Re: GitHub Actions

On Wed, Nov 6, 2019 at 3:51 AM Carlton Gibson wrote: > Hey Shai. > > On Wednesday, 6 November 2019 08:43:21 UTC+1, Shai Berger wrote: >> >> >> Is there benefit enough in GitHub Actions (over Jenkins) to justify a >> move from an open-source based solution? >> > > I don't think we have to move awa

Re: GitHub Actions

On Wednesday, November 6, 2019 at 4:48:11 PM UTC+1, Tom Forbes wrote: > > The usage limits are documented here: > https://help.github.com/en/github/automating-your-workflow-with-github-actions/about-github-actions#usage-limits. > > I’m not sure how they apply to organisations (maybe just “free

Re: GitHub Actions

Here it is: https://github.com/orf/django-github-actions/tree/master/.github/workflows There are two actions I’ve added here: a lint step and a matrix of sqlite tests (Windows, MacOS and Ubuntu * py36 and py37). It’s a

Re: GitHub Actions

Yes there will be. Now Github has added caching I think we are good to go. I will send a link here with the longer running on my fork and we can look at starting there. Once (if?) that’s merged then we can enable the “allow forks to run actions” option and we can iteratively add more tests as me

Re: GitHub Actions

Right, but there has to be some changes done i think. On Wed 6 Nov, 2019, 6:05 PM Florian Apolloner, wrote: > > > On Wednesday, November 6, 2019 at 8:43:21 AM UTC+1, Shai Berger wrote: >> >> Is there benefit enough in GitHub Actions (over Jenkins) to justify a >> move from an open-source based s

Re: GitHub Actions

Can we use pythongui library for that and then use selenium for testing . On Wed 6 Nov, 2019, 2:21 PM Carlton Gibson, wrote: > Hey Shai. > > On Wednesday, 6 November 2019 08:43:21 UTC+1, Shai Berger wrote: >> >> >> Is there benefit enough in GitHub Actions (over Jenkins) to justify a >> move fro

Re: GitHub Actions

On Wednesday, November 6, 2019 at 8:43:21 AM UTC+1, Shai Berger wrote: > > Is there benefit enough in GitHub Actions (over Jenkins) to justify a > move from an open-source based solution? > Yes, less server costs (even if sponsored). Less things to maintain for us (Jenkins is a beast). Better

Re: GitHub Actions

Hey Shai. On Wednesday, 6 November 2019 08:43:21 UTC+1, Shai Berger wrote: > > > Is there benefit enough in GitHub Actions (over Jenkins) to justify a > move from an open-source based solution? > I don't think we have to move away entirely but it would be good to bring in something else... (o

Re: GitHub Actions

On Tue, 5 Nov 2019 13:35:24 -0800 (PST) Florian Apolloner wrote: > > Ui, seems like we can start using our own runners: > https://github.blog/2019-11-05-self-hosted-runners-for-github-actions-is-now-in-beta/ > > -- seems like github actions is becoming more and more a jenkins > replacement :

Re: GitHub Actions

On Thursday, October 31, 2019 at 2:33:29 PM UTC+1, Florian Apolloner wrote: > > > > On Thursday, October 31, 2019 at 11:08:49 AM UTC+1, Tom Forbes wrote: >> >> 1. How do we support Oracle? >> > > For now we don't > Ui, seems like we can start using our own runners: https://github.blog/2019-11-0

Re: GitHub Actions

On Thursday, October 31, 2019 at 11:08:49 AM UTC+1, Tom Forbes wrote: > > 1. How do we support Oracle? > For now we don't 2. Can we (or do we want to?) unify it somehow with docker-box? > If it makes sense yes, if it makes the actions horribly complex and it would be more action-like in anoth

Re: GitHub Actions

Nice, I've been playing with GitHub actions and I'm impressed. Will move my projects over from Travis at some point. Thanks for your work Tom (Likewise on side note - I did not see Johannes' first message) On Thu, 31 Oct 2019 at 10:08, Tom Forbes wrote: >  >  > Yep! My life has been unexpecte

Re: GitHub Actions

 Yep! My life has been unexpectedly busy the last few weeks so I’ve made no progress on it, but my idea is to prototype it in that repo before making a MR to Django itself. Starting with limiting would be easiest, but I actually don’t think it would be particularly hard to have the full suit

Re: GitHub Actions

I think Tom Forbes started working on it already, you might wanna sync up with him: https://github.com/orf/django-github-actions On Thursday, October 31, 2019 at 10:40:47 AM UTC+1, Johannes Hoppe wrote: > > I would love to give Selenium a try. O god I hate it when selenium tests > just randomly

Re: GitHub Actions

I would love to give Selenium a try. O god I hate it when selenium tests just randomly fail and I can't restart them. I think the ability to just restart actions as a user is going to be a major improvement to the current workflow. On Thursday, October 31, 2019 at 6:36:24 PM UTC+9, Florian Apoll

Re: GitHub Actions

Hi, yes I had the same thought yesterday. I think trying with linters first should be an easy low hanging fruit (and to get a feeling for it). Tests in general might get a bit harder. Cheers, Florian On Thursday, October 31, 2019 at 10:30:10 AM UTC+1, Johannes Hoppe wrote: > > Hey there, > > I