Re: Extending django.contrib.auth.models Group name to be 191 character max_length

2018-11-14 Thread Tim Allen
I've amended the PR to be 150 characters rather than 191. Thanks for doing the digging which explains why I had 191 characters stuck in my head. I'm in the "as long as possible to cover the most possible cases" camp, but 150 would seem to hit the 99.9%, so let's call it a win! 🎉 Regards,

Re: Extending django.contrib.auth.models Group name to be 191 character max_length

2018-11-14 Thread Carlton Gibson
(Before I start, I'm +1 but... 🙂) Just having a quick go over the history here... * Original discussion floated a change to 100 or 150 chars. * Aymeric valued fixing the issue for 99.999% of cases. * Tom Christie wanted an "human value", not a machine one. 100 chars was suggested.

Re: Extending django.contrib.auth.models Group name to be 191 character max_length

2018-11-13 Thread Aymeric Augustin
That seems all right to me. -- Aymeric. > On 13 Nov 2018, at 16:56, joh...@alumni.upenn.edu wrote: > > If the other fields are also 191, i see no reason not to make the change. It > should be a non-breaking change. And Yes i am that colleague... > > On Tuesday, November 13, 2018 at 4:52:2

Re: Extending django.contrib.auth.models Group name to be 191 character max_length

2018-11-13 Thread johnrp
If the other fields are also 191, i see no reason not to make the change. It should be a non-breaking change. And Yes i am that colleague... On Tuesday, November 13, 2018 at 4:52:24 PM UTC+1, Tim Allen wrote: > > Greetings, > > Over the past few releases, several CharFields in django.contrib.au