Re: Django Channels doesn’t conform to Django middleware specifications

2018-08-28 Thread Andrew Godwin
Just to say that I've reopened the original issue in question as it's clear now this needs to be fixed. I won't be able to get to writing a fix for a bit, though, so if someone else wants to they should. Andrew On Tue, Aug 28, 2018 at 5:41 AM John Obelenus wrote: > Just finished reading both bu

Re: Django Channels doesn’t conform to Django middleware specifications

2018-08-28 Thread John Obelenus
Just finished reading both bug reports and I see the file loader lookup in whitenoise. This explains a lot actually. We are still on Channels 1, and when we tried an upgrade to Channels 2, but encountered terrible performance at load and had to undo it. On Tuesday, August 28, 2018 at 8:00:17 AM

Re: Django Channels doesn’t conform to Django middleware specifications

2018-08-28 Thread John Obelenus
Can I ask a dumb question? Why did you only discover this with adding Whitenoise, and not the default/common middleware stack that comes in django? Asking that question in another way: What is specific to whitenoise that this constant loading of middleware causes such a perf hit? This question