Re: Django 2.2 and the watchman reloader

2019-06-16 Thread Tom Forbes
Just an update to this: I've made a WIP PR to add watchdog support here: https://github.com/django/django/pull/11480 I'd like to disable it on Windows and MacOS, and there are some tricky issues to resolve around how events are triggered (watchdog uses a number of threads internally, and we need t

Re: Django 2.2 and the watchman reloader

2019-02-25 Thread Tom Forbes
I have a small PR here to remove the “watchman unavailable” message, whilst keeping the one that specifies which reloader we are using: https://github.com/django/django/pull/11025. On 21 February 2019 at 20:52:29, Claude Paroz (cla...@2xlibre.net) wrote: Le jeudi 21 février 2019 21:43:43 UTC+1

Re: Django 2.2 and the watchman reloader

2019-02-21 Thread Claude Paroz
Le jeudi 21 février 2019 21:43:43 UTC+1, Tom Forbes a écrit : > > Hey Claude, > Thanks for your feedback on the feature, I fully agree with you. I think > we should remove that warning message about the missing package. I will > make a PR to do that. > I'm not completely sure it's a good idea to

Re: Django 2.2 and the watchman reloader

2019-02-21 Thread Tom Forbes
Hey Claude, Thanks for your feedback on the feature, I fully agree with you. I think we should remove that warning message about the missing package. I will make a PR to do that. Regarding creating another reloader: it should not be that difficult to do at all since we have all the other pieces in

Re: Django 2.2 and the watchman reloader

2019-02-21 Thread Claude Paroz
I have a POC patch here: https://github.com/django/django/pull/11014 Claude -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group. To unsubscribe from this group and stop receiving emails from it, send an email

Re: Django 2.2 and the watchman reloader

2019-02-21 Thread Claude Paroz
Le jeudi 21 février 2019 19:48:31 UTC+1, Dan Davis a écrit : > > Claude, > > I've tested a Django based application on 2.2b1 without watchman on > Windows, it does tell you about watchman, but it doesn't fail to run. > Apparently, it falls back to the old way of reloading. Is this not the > b

Re: Django 2.2 and the watchman reloader

2019-02-21 Thread Dan Davis
Claude, I've tested a Django based application on 2.2b1 without watchman on Windows, it does tell you about watchman, but it doesn't fail to run. Apparently, it falls back to the old way of reloading. Is this not the behavior on Debian/Ubuntu? On Thu, Feb 21, 2019 at 12:28 PM Claude Paroz wrot