Re: Changing widget rendering templates

2021-06-06 Thread Tom Carrick
I agree with everything said here so far. I just want to add that I wonder if it is perhaps a good idea to deprecate and dedocument as_p and friends, but leave them in the code base for existing projects? Tom On Sun, 6 Jun 2021, 09:25 smi...@gmail.com, wrote: > Hi All, > > Thanks for your reps

Re: Changing widget rendering templates

2021-06-06 Thread smi...@gmail.com
Hi All, Thanks for your repsonses and guidance. I think for the widget changes we have far less flexibility than with forms where folk are already using various as_* functions. I'll therefore progress with the widget ticket as a breaking change. For the form changes I think it makes sense to

Re: Changing widget rendering templates

2021-06-05 Thread Thibaud Colas
Hi all, I wanted to mention a couple more things that might help in the decision: - There is no direct accessibility issue *for end users* from `as_p` that I know of. The only issue is its propensity to making people create forms with invalid HTML (see #31189

Re: Changing widget rendering templates

2021-06-05 Thread 'Adam Johnson' via Django developers (Contributions to Django itself)
I think a breaking change for the widget HTML is fine too, if it improves everyone’s apps. Perhaps documenting in the release notes how to undo it (eg copy this template file into your project, reconfigure the widget to use the template like so) will make it easier for folks with incompatible CSS t

Re: Changing widget rendering templates

2021-06-05 Thread Carlton Gibson
Hi David. Thanks for this. Sorry for the slow pick-up: DjangoCon this week. :) I'd say option 1: It's an accessibility change and we should just opt people into that. IIRC there are some small improvements to the current HTML (aria roles and such) that would improve accessibility even if not