Re: A base compression middleware class

2021-06-15 Thread Tom Carrick
It's also worth noting that the security issue mentioned in the docs[1] makes it unsuitable for many (most?) Django projects, unfortunately, and brotli is also susceptible to this attack. It's probably not something I'd be keen on encouraging the use of, though I also think the idea in principle i

Re: A base compression middleware class

2021-06-14 Thread Curtis Maloney
Hi Illia, I like the idea here, and your design looks sensible at first blush, but I feel conflicted. As much as I like the idea of allowing more flexibility and future-proofing this middleware, AIUI the gzip middleware is generally discouraged, as it's typically more efficient to have your we