Re: Complex aggregate and expression composition.

2012-04-10 Thread Nate Bragg
> I took a quick look at your patch. I don't have more time now, so just > some quick comments: > [...] I think the approach you have taken is correct in general. I would > encourage to check > if you can somewhat easily incorporate the conditional aggregate support > (#11305) > into the Expressio

RE: Complex aggregate and expression composition.

2012-03-20 Thread Kääriäinen Anssi
I took a quick look at your patch. I don't have more time now, so just some quick comments: - In general, the approach where aggregates are just expressions sounds and looks valid. - I would not worry about the extra time used in djangobench. However, profiling why there is extra tim