Re: Proposal to remove ModelAdmin's collection of actions from superclasses

2018-11-05 Thread charettes
I agree with you Tim. +1 from me. Le lundi 5 novembre 2018 12:03:55 UTC-5, Tim Graham a écrit : > > Hi, > > A recent bug report [1] brought up the fact that ModelAdmin collects > actions from superclasses. For example: > > class BaseAdmin: > actions = ['a'] > > class SubAdmin(BaseAdmin): >

Re: Proposal to remove ModelAdmin's collection of actions from superclasses

2018-11-05 Thread Carlton Gibson
The idea was that you could define a base admin and have the actions appear without having to redeclare them. The only question is are people actually using that? (I can't think of a third-party app that provides an admin with actions that you're meant to subclass for instance — anyone?) If

Re: Proposal to remove ModelAdmin's collection of actions from superclasses

2018-11-05 Thread Adam Johnson
I agree, it shouldn’t be doing something so surprising and undocumented. On Mon, 5 Nov 2018 at 17:03, Tim Graham wrote: > Hi, > > A recent bug report [1] brought up the fact that ModelAdmin collects > actions from superclasses. For example: > > class BaseAdmin: > actions = ['a'] > > class Su

Proposal to remove ModelAdmin's collection of actions from superclasses

2018-11-05 Thread Tim Graham
Hi, A recent bug report [1] brought up the fact that ModelAdmin collects actions from superclasses. For example: class BaseAdmin: actions = ['a'] class SubAdmin(BaseAdmin): actions = ['b'] SubAdmin will have action 'a' and 'b'. The behavior isn't tested and only mentioned in passing i