I've used autopep8 to make some additional cleanup -- see this pull
request: https://github.com/django/django/pull/1875
--
You received this message because you are subscribed to the Google Groups
"Django developers" group.
To unsubscribe from this group and stop receiving emails from it, send
On 10/09/2013 08:38 PM, Tim Graham wrote:
A drawback is that it will introduce some noise in the commit history in
the short term and make git blame less efficient.
Note however that there is “-w” option for git blame, which does the
following: “Ignore whitespace when comparing the parent’s v
On 10/09/2013 12:38 PM, Tim Graham wrote:
> I'd like to propose cleaning up Django's codebase so that we can run
> flake8 (with some rules ignored) as a presubmit check (for example,
> hooked into pull request submissions).
>
> Our docs currently state: "Note, however, that patches which only remo
On 9 oct. 2013, at 20:38, Tim Graham wrote:
> If accepted, I'll put together a more concrete proposal that includes which
> errors we'll ignore, etc.
Sure, go ahead!
I'm always embarrassed when contributors work on large cleanup patches, because
they're especially tedious to review and don't
On Wed, Oct 9, 2013, Tim Graham wrote:
>Our docs currently state: "Note, however, that patches which only remove
>whitespace (or only make changes for nominal PEP 8 conformance) are likely
>to be rejected, since they only introduce noise rather than code
>improvement. Tidy up when you're next
+1
- Anssi
On Wednesday, October 9, 2013 9:38:17 PM UTC+3, Tim Graham wrote:
>
> I'd like to propose cleaning up Django's codebase so that we can run
> flake8 (with some rules ignored) as a presubmit check (for example, hooked
> into pull request submissions).
>
> Our docs currently state: "No
+1 hip hip cleanup!
On Wed, Oct 9, 2013 at 4:38 PM, Tim Graham wrote:
> things a
--
juanpex
--
You received this message because you are subscribed to the Google Groups
"Django developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to django-
I'd like to propose cleaning up Django's codebase so that we can run flake8
(with some rules ignored) as a presubmit check (for example, hooked into
pull request submissions).
Our docs currently state: "Note, however, that patches which only remove
whitespace (or only make changes for nominal P
