Re: Proposal to add pre-commit

2020-11-17 Thread smi...@gmail.com
Hi All, Thanks for your comments. Adam -- yes, I quite like pre-commit-hooks it reminds me of the 'pick and mix' when I was a kid. We can easily add more here, as I guess the risk is low. I like the idea of running the binaries through the system but I wonder if it's too much here. That is,

Re: Proposal to add pre-commit

2020-11-08 Thread Carlton Gibson
I’d be +1 here. I’ve found pre-commit very useful on other projects. -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group. To unsubscribe from this group and stop receiving emails from it, send an email to djan

Re: Proposal to add pre-commit

2020-11-06 Thread Adam Johnson
Hi David I like pre-commit too. I think it would be a great addition. Your initial setup looks good - and perhaps we can add a few more hooks from pre-commit-hooks like check-case-conflict and check-json. One thing I prefer to do is use pre-commit to run binaries through "system" (e.g. [1]). This

Proposal to add pre-commit

2020-11-06 Thread smi...@gmail.com
Hi All I have opened a ticket[1] which proposes to add pre-commit[2] to Django, and wish to gather thoughts on it here. For anyone not familiar pre-commit checks for simple issues before each `git commit`. The aim is to try and catch format errors closer to the developer and therefore reduce