Re: Proposal for Table Functions

2020-05-19 Thread Petr Přikryl
Linking the issue https://code.djangoproject.com/ticket/31609 Dne pondělí 18. května 2020 13:57:49 UTC+2 Ahmad A. Hussein napsal(a): > > Concerning tests, I did not mean to comment about the tests you wrote. I > used the third party py-test django app as an example of an app that does > need wo

Re: Proposal for Table Functions

2020-05-18 Thread Ahmad A. Hussein
Concerning tests, I did not mean to comment about the tests you wrote. I used the third party py-test django app as an example of an app that does need work in core to function better, not as a comment about your usage of tests. You're more than free to work the way you want to :) (I like pytest

Re: Proposal for Table Functions

2020-05-17 Thread Petr Přikryl
ad 1. I was testing it on PostgreSQL only. But: - Oracle is feasible through custom extendings in compiler https://livesql.oracle.com/apex/livesql/file/content_C87XCH8SE085LMS3C5KR03VFS.html - MySQL is also feasible https://stackoverflow.com/a/23421816/1763888 - SQLite has some speci

Re: Proposal for Table Functions

2020-05-17 Thread Ahmad A. Hussein
I'm not an expert or even an amateur at the ORM, but here are my thoughts on the matter: 1. Does it carry over well across the four databases? 2. Is it necessary to include it as part of core versus a third-party app? 3. What specific use case will benefit from adopting this idea? I ask the second

Proposal for Table Functions

2020-05-17 Thread Petr Přikryl
Hi, I have just implemented Table Function support on Django 2.1. What do you think about adopting it into Django itself? https://gist.github.com/petrprikryl/7cd765cd723c7df983de03706bf27d1a It is all about passing function parameters into BaseTable and Join classes https://github.com/django/d