Re: Proposal: Make filters in admin persistent (#6903)

2009-01-23 Thread Ramiro Morales
On Fri, Nov 14, 2008 at 2:28 PM, Jonas Pfeil wrote: > > Just to be clear we are talking about the same thing: With "persistent > filters" I just mean "going back to the _filtered_ change list after > editing an item". I don't think it makes sense to make them any more > persistent :) Clicking on

Re: Proposal: Make filters in admin persistent (#6903)

2008-11-14 Thread Malcolm Tredinnick
On Fri, 2008-11-14 at 08:28 -0800, Jonas Pfeil wrote: > Just to be clear we are talking about the same thing: With "persistent > filters" I just mean "going back to the _filtered_ change list after > editing an item". I don't think it makes sense to make them any more > persistent :) Clicking on

Re: Proposal: Make filters in admin persistent (#6903)

2008-11-14 Thread Jonas Pfeil
Just to be clear we are talking about the same thing: With "persistent filters" I just mean "going back to the _filtered_ change list after editing an item". I don't think it makes sense to make them any more persistent :) Clicking on the link to the change list on the admin home page should give

Re: Proposal: Make filters in admin persistent (#6903)

2008-11-13 Thread Malcolm Tredinnick
On Tue, 2008-11-11 at 13:47 -0800, David Cramer wrote: > Well I'm not sure storing multiple search paths is too good of an > idea, as you increase the size of the session significantly, and then > have to worry about expiring those or clearing them somehow. The > session just keeps it for that us

Re: Proposal: Make filters in admin persistent (#6903)

2008-11-11 Thread David Cramer
I was implying that if I'm in email admin, and there's filters there, once I leave email admin, there's no reason to keep that information around. Going back to the email admin should give a clean start, that's how typical applications like that work (at least every one that I've ever used). But

Re: Proposal: Make filters in admin persistent (#6903)

2008-11-11 Thread George Vilches
I wasn't thinking that the filters would be preserved across *different* models or admin pages, only within them. So, you'd keep some sort of dictionary, keyed based on the particular admin URL, model, or some other easily achievable unique piece of information per screen. I wouldn't exp

Re: Proposal: Make filters in admin persistent (#6903)

2008-11-11 Thread David Cramer
I guess you're right. This is just for admin so it's not a huge deal. It will feel weird howerver, if I somehow go to a search results page and it remembers my filters when I was visiting something else before that. So it'd need to handle clearing it at the right time as well. On Nov 11, 3:51 pm

Re: Proposal: Make filters in admin persistent (#6903)

2008-11-11 Thread George Vilches
Don't sessions already have standard expirations in them? Besides that, this is the admin, it's not a tool for every user of your application to be in, so there will only be a few larger sessions (and larger is still only a few K at most, if you have lots and lots of models you're filteri

Re: Proposal: Make filters in admin persistent (#6903)

2008-11-11 Thread David Cramer
Well I'm not sure storing multiple search paths is too good of an idea, as you increase the size of the session significantly, and then have to worry about expiring those or clearing them somehow. The session just keeps it for that users session, vs whoever else happens to visit that url (say I pa

Re: Proposal: Make filters in admin persistent (#6903)

2008-11-11 Thread George Vilches
I definitely second this. The extra bonus to storing it in the session is that you can maintain your search state on multiple admin pages/models independently without overflowing the URL. Naturally if you do it this way, you'd also want to have a visible "clear filters" link so that ther

Re: Proposal: Make filters in admin persistent (#6903)

2008-11-11 Thread David Cramer
Before this gets accepted, I'd like to throw in the proposal of storing this in the session vs a huge URL. That and a hash seem to be the common approach to storing search paths. On Nov 11, 7:19 am, Jonas Pfeil <[EMAIL PROTECTED]> wrote: > Currently if you search in the admin, use some kind of fi

Proposal: Make filters in admin persistent (#6903)

2008-11-11 Thread Jonas Pfeil
Currently if you search in the admin, use some kind of filter or even just go to the second page in the change list this selection is reset when you edit an item and hit save. The user gets the default list again. Needless to say this can be quite annoying. Especially if you want to edit a specifi