Re: Proposal: Decouple messages from contrib.auth

2008-10-28 Thread SmileyChris
On Oct 29, 5:50 am, "Rob Hudson" <[EMAIL PROTECTED]> wrote: > From the looks of it, the patch onhttp://code.djangoproject.com/ticket/4604 > is heading this direction > re: backwards compatible and part of contrib.sessions. > > Maybe SmileyChris can speak to both of these points and if it could be

Re: Proposal: Decouple messages from contrib.auth

2008-10-28 Thread Rob Hudson
On 10/28/08, Jacob Kaplan-Moss <[EMAIL PROTECTED]> wrote: > > On Mon, Oct 20, 2008 at 12:33 PM, Rob Hudson <[EMAIL PROTECTED]> wrote: > > I think decoupling messages from contrib.auth is a worthy step to > > making auth a little bit more reusable. > > Agreed. However, doing this in a backwards-

Re: Proposal: Decouple messages from contrib.auth

2008-10-28 Thread Jacob Kaplan-Moss
On Mon, Oct 20, 2008 at 12:33 PM, Rob Hudson <[EMAIL PROTECTED]> wrote: > I think decoupling messages from contrib.auth is a worthy step to > making auth a little bit more reusable. Agreed. However, doing this in a backwards-compatible manner is going to be tricky. > By doing so, however, Django

Re: Proposal: Decouple messages from contrib.auth

2008-10-26 Thread Ludvig Ericson
On Oct 20, 2008, at 20:33, Rob Hudson wrote: > I think decoupling messages from contrib.auth is a worthy step to > making auth a little bit more reusable. +1. Was hacking around with the auth stuff, and for the life of me couldn't see how messages and authentication were the same thing in any reg

Re: Proposal: Decouple messages from contrib.auth

2008-10-26 Thread Travis Cline
> Also adding in a pointer to ticket 4604 [1] and django-session- > messages [2] which is based on the 4604 patch. > > Carl > >  [1]http://code.djangoproject.com/ticket/4604 >  [2]http://code.google.com/p/django-session-messages/ Started my own 4604 extraction before django-session-messages was o

Re: Proposal: Decouple messages from contrib.auth

2008-10-21 Thread Carl Meyer
> I think that auth messages are the wrong way to do it most of the time > they are used (including django core code) anyway. They are usually > used to inform that an action worked (or didn't) -- this should be > done as session messages, not user messages. +1 to this, and also to decoupling mes

Re: Proposal: Decouple messages from contrib.auth

2008-10-21 Thread SmileyChris
I think that auth messages are the wrong way to do it most of the time they are used (including django core code) anyway. They are usually used to inform that an action worked (or didn't) -- this should be done as session messages, not user messages. --~--~-~--~~~---~--

Re: Proposal: Decouple messages from contrib.auth

2008-10-20 Thread Rob Hudson
On Mon, Oct 20, 2008 at 11:33 AM, Rob Hudson <[EMAIL PROTECTED]> wrote: > * Should a pre-existing reusable app (like django-notification[2]) > be used/considered instead? > [2] http://code.google.com/p/django-notification/ I actually meant to link to the django-notices app, which has the benefit

Proposal: Decouple messages from contrib.auth

2008-10-20 Thread Rob Hudson
Hi Devs, I just posted a question on Django users about how to best remove the extra query to auth_messages on every request while still using contrib.auth and contrib.admin in my own code[1]. This led me to the thought that contrib.auth should follow the reusable apps mantra of do only one thin