Re: Proposal: Add additional password validators (auth/password_validation.py)

2019-05-27 Thread Adam Johnson
No worries, I wouldn't say I beat you, this is just a discussion :) Looking forward to your future contributions On Wed, 22 May 2019 at 02:10, Brad Solomon wrote: > Thanks Adam--the thoroughness of your response makes me more, rather than > less, interested in contributing further to Django. An

Re: Proposal: Add additional password validators (auth/password_validation.py)

2019-05-21 Thread Brad Solomon
Thanks Adam--the thoroughness of your response makes me more, rather than less, interested in contributing further to Django. And I must admit you have me beat on just about all points raised. As a new contributor, hearing your framing of the consideration that goes into feature requests was help

Re: Proposal: Add additional password validators (auth/password_validation.py)

2019-05-21 Thread Adam Johnson
Hi Brad, I appreciate no one has replied here for some time, and your ticket was closed rapidly after your work creating the code. I can imagine it might be a bit frustrating. Thanks for trying to improve Django. I see you've submitted some other PR's since, thanks for that work. My thoughts on

Proposal: Add additional password validators (auth/password_validation.py)

2019-05-06 Thread Brad Solomon
I recently opened a ticket (30442) proposing to add more password validators to auth/password_validation.py, which was promptly closed. I'm not here to cry and moan about it being closed as wontfix, but rather, to raise some questions and show why I think more discussion is warranted. Tickets: