Re: Predicate as suggested new feature to extend url resolver process

2013-05-23 Thread Rach Belaid
Hi Jacob, I understand your points. Sorry if my initial post was not properly fitted. Thanks for taking the time to clarify this points. I was maybe not clear enough or got lost in translation in my post/ ticket/pr. but I tried to specify my intention in all of them: "I'm personally not convince

Re: Predicate as suggested new feature to extend url resolver process

2013-05-22 Thread Jacob Kaplan-Moss
Hi Rach -- Thanks for the clarification. I'd like to make three broader points. They may not seem like they're directly addressing your proposal, but stick with me, I promise this comes together to your specific proposal at the end: 1. "But framework X does it like this" isn't a particularly good

Re: Predicate as suggested new feature to extend url resolver process

2013-05-22 Thread Rach Belaid
Thanks for the feedback. I assume If it's not use then performance should be the same. But I don't know if the single check for the presence of the attribute or not would affect much the performance. The goal of this feature is offering a hook to allow people extend a bit the routing logic. Wh

Re: Predicate as suggested new feature to extend url resolver process

2013-05-22 Thread Sean Bleier
I think what Rach is suggesting is different from @require_GET, @require_POST, etc. The patch essentially makes a view invisible if the predicate function returns False. I'm not sure this would be good for inclusion to django, since you are tying url resolution to application state . This could h

Re: Predicate as suggested new feature to extend url resolver process

2013-05-22 Thread Rach Belaid
It's different in the way that the view url won't match and the url resolving will continue, where require_GET would raise a django.http.HttpResponseNotAllowed ** I had to change the UrlResolver a bit ** This allow to have same urls which pick the right view base on the state/values of the reque

Re: Predicate as suggested new feature to extend url resolver process

2013-05-22 Thread Jacob Kaplan-Moss
I'm not sure I understand what you're proposing here. How is this different from @require_GET, @require_POST, and friends? Jacob On Wed, May 22, 2013 at 11:05 AM, Rach Belaid wrote: > I just did a pull request resulting of my last Django sprints for > adding a new feature in Django. > > https://

Predicate as suggested new feature to extend url resolver process

2013-05-22 Thread Rach Belaid
I just did a pull request resulting of my last Django sprints for adding a new feature in Django. https://code.djangoproject.com/ticket/20479 The idea is being able to have more control on the url resolving process. I have no merit behind the idea of predicate. Predicate is one of my favorite fe