Re: Possible thread-safety regression for sitemaps in r13980

2010-10-11 Thread Luke Plant
On Sun, 2010-10-10 at 15:17 -0700, Gabriel Hurley wrote: > I believe you are correct, since sitemaps are global objects, this > would not be thread-safe. Fixing it should be fairly easy, however. > > Setting self.request was only necessary for two reasons: > > 1. Sitemap.get_urls() uses it, but

Re: Possible thread-safety regression for sitemaps in r13980

2010-10-10 Thread Gabriel Hurley
I believe you are correct, since sitemaps are global objects, this would not be thread-safe. Fixing it should be fairly easy, however. Setting self.request was only necessary for two reasons: 1. Sitemap.get_urls() uses it, but either the request or the current_site variable could be easily be pa

Possible thread-safety regression for sitemaps in r13980

2010-10-10 Thread Justin Bronn
After r13980, GIS sitemaps were broken, and when attempting to fix I had questions about the underlying implementation of the changeset: http://code.djangoproject.com/changeset/13980/django/trunk/django/contrib/sitemaps/views.py In the loop iterating over the `sitemaps` argument (L12), the `site`