Re: Oracle branch: review notes

2007-06-11 Thread Ian Kelly
Just wanted to mention that the issues Malcolm brought up here have since been resolved, and I believe the branch is ready to be merged: 1) Many backends.supports_tablespaces checks: we decided to leave this alone. 2) Backwards incompatibility with truncate_name use: this has been fixed by leavi

Re: Oracle branch: review notes

2007-06-01 Thread Malcolm Tredinnick
On Fri, 2007-06-01 at 09:50 -0500, Jacob Kaplan-Moss wrote: > On 6/1/07, Malcolm Tredinnick <[EMAIL PROTECTED]> wrote: > > I suspect my laxness has been holding up the boulder-oracle-sprint > > branch merge. > > Yeah, I've also been bad about getting my review notes in. Now that you've > started

Re: Oracle branch: review notes

2007-06-01 Thread Malcolm Tredinnick
On Fri, 2007-06-01 at 11:05 -0600, Ian Kelly wrote: > Hi Malcolm, thanks for taking the time to look this over. > > On 6/1/07, Malcolm Tredinnick <[EMAIL PROTECTED]> wrote: > > (1) In core/management.py, there are a lot of lines that are > > doing the equivalent of; > > > >

Re: Oracle branch: review notes

2007-06-01 Thread Russell Keith-Magee
On 6/1/07, Jacob Kaplan-Moss <[EMAIL PROTECTED]> wrote: > > Or does one of the other core devs have access to an Oracle install? I'm > pretty > sure Adrian doesn't, but if Russ or Malcolm does I'm happy to let one of them > do > the merge... I have access to an Oracle install at work. However,

Re: Oracle branch: review notes

2007-06-01 Thread Ian Kelly
Hi Malcolm, thanks for taking the time to look this over. On 6/1/07, Malcolm Tredinnick <[EMAIL PROTECTED]> wrote: > (1) In core/management.py, there are a lot of lines that are > doing the equivalent of; > > if opts.db_tablespace and backend.supports_tablespaces:

Re: Oracle branch: review notes

2007-06-01 Thread Ian Kelly
On 6/1/07, Ian Kelly <[EMAIL PROTECTED]> wrote: > On 6/1/07, Malcolm Tredinnick <[EMAIL PROTECTED]> wrote: > > (2) The use of django.db.utils.truncate_name() introduces a > > small backwards incompatible change for all existing backends. > > With sufficiently long table and

Re: Oracle branch: review notes

2007-06-01 Thread Matt Boersma
On Jun 1, 8:50 am, "Jacob Kaplan-Moss" <[EMAIL PROTECTED]> wrote: > ... Is there perhaps a VMWare > image of a pre-installed Oracle that I can test this stuff against? Oracle had a developer program called "Oracle By Example" (OBE) that provides a VMware image with RedHat, Oracle 10gR2 RAC, etc.

Re: Oracle branch: review notes

2007-06-01 Thread Jacob Kaplan-Moss
On 6/1/07, Malcolm Tredinnick <[EMAIL PROTECTED]> wrote: > I suspect my laxness has been holding up the boulder-oracle-sprint > branch merge. Yeah, I've also been bad about getting my review notes in. Now that you've started this rolling, though, I'll just piggy-back off yours. For the most part,

Oracle branch: review notes

2007-06-01 Thread Malcolm Tredinnick
I suspect my laxness has been holding up the boulder-oracle-sprint branch merge. So, I sat down tonight with my notes, read through an updated diff and removed anything that might be evidence I was on drugs at the time. What follows is what remains. Nothing that is a showstopper for merging in her