Re: Next steps for ticket #18150

2013-02-09 Thread Steven Vargas
Added an updated patch last night. Could someone look it over? -- You received this message because you are subscribed to the Google Groups "Django developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to django-developers+unsubscr...@googlegroups.co

Re: Next steps for ticket #18150

2013-02-03 Thread Steven Vargas
Thanks, I added the tests and updated the patch file. There was another file that had to be modified in order to fix the bug. I think it is ready for review. On Sunday, February 3, 2013 3:00:26 PM UTC-8, charettes wrote: > > It looks like the appropriate module to add the test. > > The next step

Re: Next steps for ticket #18150

2013-02-03 Thread charettes
It looks like the appropriate module to add the test. The next step is to upload you patch with the test to #18150to get it reviewed. Simon Le dimanche 3 février 2013 17:26:29 UTC-5, Steven Vargas a écrit : > > Hi, back again. I wrote a test for 1815

Re: Next steps for ticket #18150

2013-02-03 Thread Steven Vargas
Hi, back again. I wrote a test for 18150, I put the test method in tests>regressiontests>file_uploads>tests.py, is this correct? The test fails with unchanged django package and passes with the patch I submitted. On Thursday, January 31, 2013 6:25:21 PM UTC-8, Steven Vargas wrote: > > Hi, I'm a

Re: Next steps for ticket #18150

2013-02-01 Thread Steven Vargas
Awesome, thanks! I'll get onto that asap. Everyone here and the IRC have been very helpful :) On Thursday, January 31, 2013 10:36:32 PM UTC-8, Russell Keith-Magee wrote: > > > On Fri, Feb 1, 2013 at 10:25 AM, Steven Vargas > > > wrote: > >> Hi, I'm a student and this is my first contribution to

Re: Next steps for ticket #18150

2013-01-31 Thread Russell Keith-Magee
On Fri, Feb 1, 2013 at 10:25 AM, Steven Vargas wrote: > Hi, I'm a student and this is my first contribution to an open source > project so I am trying to learn along the way. > > Anyways, I submitted a patch for > #18150and I was looking for > input o

Next steps for ticket #18150

2013-01-31 Thread Steven Vargas
Hi, I'm a student and this is my first contribution to an open source project so I am trying to learn along the way. Anyways, I submitted a patch for #18150and I was looking for input on where to go from here. On the IRC channel it was suggested tha