Re: New Feature discussion: making admin app & model url configurable

2018-06-29 Thread Ramez Ashraf
Taking it off from Collin's crucial suggestion https://github.com/django/django/pull/10111 Implement it as an AdminSite method, Which, after some thoughts, i think it's fair that if one wants to customize the admin urls, then they should sub class the AdminSite, Also i believe for developers relyi

Re: New Feature discussion: making admin app & model url configurable

2018-06-29 Thread Ramez Ashraf
Another comment, if i may, about the implementation after some thoughts 1- it does not customize the app_index url 2- as a consequence, the "uniformity" the admin urls may be broken So maybe there is a way, that this method `get_urls_for_model` get changed to include both the app_index, and the mo

Re: New Feature discussion: making admin app & model url configurable

2018-06-29 Thread Ramez Ashraf
Sure that's a great idea Colin ! I'm little greedy, I wanted to make it little easier, ie without needing to subclass the AdminSite... But that's absolutely great implementation too! On Fri, Jun 29, 2018, 4:07 PM Collin Anderson wrote: > Maybe we could make an AdminSite.get_urls_for_model(self,

Re: New Feature discussion: making admin app & model url configurable

2018-06-29 Thread Collin Anderson
Maybe we could make an AdminSite.get_urls_for_model(self, model, model_admin) https://github.com/django/django/pull/10108/files On Fri, Jun 29, 2018 at 8:57 AM wrote: > Personally, I'm not sure I see that much value. As I see it, the admin is > intended for technical users, not as a general adm

Re: New Feature discussion: making admin app & model url configurable

2018-06-29 Thread knyght
Personally, I'm not sure I see that much value. As I see it, the admin is intended for technical users, not as a general admin interface for end users (in this context I'm mostly talking about non-programmers). While it can and I sometimes do allow end-users to use the admin directly, I really

New Feature discussion: making admin app & model url configurable

2018-06-29 Thread Ramez Ashraf
Hello guys, I use the admin quite extensively in my work with Django, and it's awesome. One place that can use some polish is the urls. As you know, the admin urls evolve around are the / , and those two can get technical, long and in short not user friendly. Hence, I propose a new feature o