Re: My patch is gathering dust

2006-07-04 Thread Malcolm Tredinnick
On Tue, 2006-07-04 at 08:05 -0700, jws wrote: > > They should be added, since we are bound to get some edge cases wrong > > (c.f. initial SQL parsing) and having regression tests will help there. > > If you could add those, that would be great. Testing both sorts of > > quotes, backslashes, semico

Re: My patch is gathering dust

2006-07-04 Thread jws
> They should be added, since we are bound to get some edge cases wrong > (c.f. initial SQL parsing) and having regression tests will help there. > If you could add those, that would be great. Testing both sorts of > quotes, backslashes, semicolons and percentage signs would be my > suggestion for

Re: My patch is gathering dust

2006-07-04 Thread Malcolm Tredinnick
On Mon, 2006-07-03 at 23:33 -0700, jws wrote: > > (1) It's been closed twice; once each by Jacob and Adrian. Closing it or > > applying both make some sense to me, so I'm not about to go any further > > without some clarification. > > The discussion regarding the closure and subsequent re-opening

Re: My patch is gathering dust

2006-07-03 Thread jws
> (1) It's been closed twice; once each by Jacob and Adrian. Closing it or > applying both make some sense to me, so I'm not about to go any further > without some clarification. The discussion regarding the closure and subsequent re-opening are documented here- http://groups.google.com/group/dj

Re: My patch is gathering dust

2006-07-03 Thread Malcolm Tredinnick
On Mon, 2006-07-03 at 21:04 -0700, jws wrote: > I submitted a patch to the tracker some time ago that was never merged. > I'm unsure if there's some other community protocol for getting things > accepted that I need to follow. > > I've described the problem, submitted a complete, working patch, g

My patch is gathering dust

2006-07-03 Thread jws
I submitted a patch to the tracker some time ago that was never merged. I'm unsure if there's some other community protocol for getting things accepted that I need to follow. I've described the problem, submitted a complete, working patch, got buy-in from Adrian in principle, and had at least one