Re: Merge policy for cleanup commits

2013-10-09 Thread Danilo Bargen
Hm, I'm not sure I understand your e-mail. The link you just posted points to exactly the topic we're discussing right now. Maybe you meant to post another URL? Cheers, Danilo On Wednesday, October 9, 2013 9:11:09 PM UTC+2, Tomáš Ehrlich wrote: > > Relevant discussion > > https://groups.google

Re: Merge policy for cleanup commits

2013-10-09 Thread Tomas Ehrlich
Relevant discussion https://groups.google.com/forum/#!msg/django-developers/tcNVvbAv4-M/bs0zPNLqv48J Cheers, Tom Dne Mon, 8 Jul 2013 09:59:49 -0700 (PDT) Danilo Bargen napsal(a): > Hi there > > (I tried to find previous threads concerning the same topic, but could not > find any. If this i

Re: Merge policy for cleanup commits

2013-07-08 Thread Danilo Bargen
> I can't speak for other core devs, but I won't merge such PRs for a very > simple reason: it's more tedious and time-consuming to review them than to > redo them by myself. Even though there are many changes, the changes are very obvious and simple and quick to review. > If someone took advanta

Re: Merge policy for cleanup commits

2013-07-08 Thread Marc Tamlyn
I have to agree with Aymeric, despite being one of those people who wanted to fix this at times in the past. It is worth remembering that some areas of the Django code base are very old, and python coding standards in the community were not as strong when the code was written. Believe it or not, t

Re: Merge policy for cleanup commits

2013-07-08 Thread Aymeric Augustin
On 8 juil. 2013, at 18:59, Danilo Bargen wrote: > While I agree that small PRs which fix issues like whitespace should not > necessarily clutter up the commit history, I disagree for larger cleanup > commits. In some places the code has serious formatting issues (e.g. lines > that are indented

Merge policy for cleanup commits

2013-07-08 Thread Danilo Bargen
Hi there (I tried to find previous threads concerning the same topic, but could not find any. If this is already the n-th discussion about the topic, sorry about it.) I don't quite agree with the cleanup commit policy stated in the docs: Systematically remove all trailing whitespaces from your