Re: Making management forms for formsets optional

2015-06-10 Thread Patryk Zawadzki
2015-06-08 20:22 GMT+02:00 Carl Meyer : > But I think such a project needs to be approached as a full rewrite, > probably first as a third-party module and then later (if it works out > well) considered for merge as a separate replacement module. It does not > seem likely to me that tugging on indi

Re: Making management forms for formsets optional

2015-06-08 Thread Carl Meyer
On 06/07/2015 02:18 AM, Shai Berger wrote: > Semi-devil's-advocate suggestion: Replace the management form with a > management field, a hidden field with > > name = "__manage__%s" % (formsetname) > > and > > value="x" > > Then instead of taking the number of forms from a field o

Re: Making management forms for formsets optional

2015-06-08 Thread Carl Meyer
On 06/08/2015 04:11 AM, Patryk Zawadzki wrote: > 2015-06-07 10:18 GMT+02:00 Shai Berger : >> Semi-devil's-advocate suggestion: Replace the management form with a >> management field, a hidden field with >> >> name = "__manage__%s" % (formsetname) >> >> and >> >> value="x" >> >> Then

Re: Making management forms for formsets optional

2015-06-08 Thread Patryk Zawadzki
2015-06-07 10:18 GMT+02:00 Shai Berger : > Semi-devil's-advocate suggestion: Replace the management form with a > management field, a hidden field with > > name = "__manage__%s" % (formsetname) > > and > > value="x" > > Then instead of taking the number of forms from a field on a ma

Re: Making management forms for formsets optional

2015-06-07 Thread Shai Berger
Semi-devil's-advocate suggestion: Replace the management form with a management field, a hidden field with name = "__manage__%s" % (formsetname) and value="x" Then instead of taking the number of forms from a field on a management form, we can just take the accumulated leng

Re: Making management forms for formsets optional

2015-06-06 Thread Marc Tamlyn
I believe the complaint is mostly that an invalid formset will raise a 500 whereas an invalid form (should) never. There was a patch to display an error if not. My complaint is that this error can only occur if the dev has rendered the form by hand missing the management form. It's likely they woul

Re: Making management forms for formsets optional

2015-06-06 Thread Florian Apolloner
What about instead of trying to guess the forms from the input, just fix the one condition which causes the error and return 0 as totalformcount + an error marker to reraise the error in clean of the modelform? On Friday, June 5, 2015 at 11:29:21 AM UTC+1, Patryk Zawadzki wrote: > > Hi folks, >

Re: Making management forms for formsets optional

2015-06-06 Thread Tomek Paczkowski
I remember that Ruby on Rails solved problem with checkboxes with a hidden field that was added before each checkbox [1] [1]: http://apidock.com/rails/ActionView/Helpers/FormHelper/check_box On Friday, June 5, 2015 at 11:29:21 AM UTC+1, Patryk Zawadzki wrote: > > Hi folks, > > I've talked to Ma

Re: Making management forms for formsets optional

2015-06-05 Thread Patryk Zawadzki
Playground: https://github.com/django/django/pull/4797 -- Patryk Zawadzki I solve problems. -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group. To unsubscribe from this group and stop receiving emails from it

Making management forms for formsets optional

2015-06-05 Thread Patryk Zawadzki
Hi folks, I've talked to Marc about fixing the case where a formset will raise an uncaught ValidationError when instantiated with a missing or broken management form. This has caused us great pain when dealing with vulnerability scanners that tend to POST random crap to each endpoint they find as